On 06/15/2010 04:11 PM, Serge E. Hallyn wrote:
> Thanks for the sample text; it looked good to me on a first read.
Are
> you willing to finish out this patch by also including the patch to
> Makefile.am to generate drvlxc.html and distribute the new file?
Uh, sure. As I got yelled at last time for not sending the .in file
I was sure it was in there. But I see it, will send an update.
Hmm, we're probably confusing each other. Sorry about that ;)
Your previous email attached drvlxc.html.in, and I thought it was a new
file; but looking at git, it is already an existing file. So the
question now is generating the diff between your version and what is
already in git.
I used ubuntu lucid. I'll try to reproduce in an uptodate fedora
13.
However LIBVIR_LXC_CMD shouldn't be in the xml at all, rather the
result of
find /usr -name libvirt_lxc
should take its place.
Doh! Yep, that would explain it. I'll try again ;)
(I haven't yet attacked the second example, so if you prefer to wait
for a single complete update, I'll try to get to that soon-ish)
At this point, since you are improving an existing file, rather than
writing a new one, it's a lot easier to maintain your changes in git and
post just the changeset that describes the differences. The
README-hacking file has some hints for first-time git users, and both
the list and IRC can serve as additional resources if you have more
questions.
http://libvirt.org/git/?p=libvirt.git;a=blob;f=README-hacking
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org