If a program that is using this mock calls canonicalize_file_name() as the very first function then it will face SIGSEGV because real_canonicalize_file_name is uninitialized. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; --- tests/virfilemock.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/virfilemock.c b/tests/virfilemock.c index 89e14c5b67..106032f857 100644 --- a/tests/virfilemock.c +++ b/tests/virfilemock.c @@ -177,6 +177,9 @@ statfs(const char *path, struct statfs *buf) char * canonicalize_file_name(const char *path) { + + init_syms(); + if (getenv("LIBVIRT_MTAB")) { const char *p; char *ret; -- 2.21.0

Introduced by ff376c6283c97. Previously, init_syms() was called from stat() mock and its friends. This is crucial because checkPath() might call printFile() which in turn calls real_fopen(). But if stat() or one of its friends is the first function called then because of lacking init_syms() call no real_* is initialized. The other thing is that we really want the recorded action to be "stat" instead of __FUNCTION__ because there's no good in recording that it was __xstat64 who touched some file. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; --- tests/virtestmock.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/virtestmock.c b/tests/virtestmock.c index bc62312444..ad6958ac87 100644 --- a/tests/virtestmock.c +++ b/tests/virtestmock.c @@ -190,7 +190,9 @@ int access(const char *path, int mode) } -#define VIR_MOCK_STAT_HOOK CHECK_PATH(path) +#define VIR_MOCK_STAT_HOOK \ + init_syms(); \ + checkPath(path, "stat") #include "virmockstathelpers.c" -- 2.21.0

If the source tree was freshly configured and no objects are built yet then 'make check-access' has no test to run. Build the sources beforehand. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index eba5916352..0d8bb733e6 100644 --- a/Makefile.am +++ b/Makefile.am @@ -83,7 +83,7 @@ srpm: clean check-local: all tests -check-access: +check-access: all @($(MAKE) $(AM_MAKEFLAGS) -C tests check-access) MAINTAINERCLEANFILES = .git-module-status -- 2.21.0