On Thu, Oct 03, 2019 at 11:25:32AM +0200, Stefano Garzarella wrote:
On Thu, Oct 03, 2019 at 10:20:26AM +0100, Daniel P. Berrangé wrote:
> On Thu, Oct 03, 2019 at 11:10:02AM +0200, Stefano Garzarella wrote:
> > Signed-off-by: Stefano Garzarella <sgarzare(a)redhat.com>
> > ---
> > updater/virt-tools/config.ini | 6 ++++++
> > updater/virt-tools/images/sgarzare.png | Bin 0 -> 17713 bytes
> > 2 files changed, 6 insertions(+)
> > create mode 100644 updater/virt-tools/images/sgarzare.png
> >
> > diff --git a/updater/virt-tools/config.ini b/updater/virt-tools/config.ini
> > index 3845f25..6b4b5ec 100644
> > --- a/updater/virt-tools/config.ini
> > +++ b/updater/virt-tools/config.ini
> > @@ -188,3 +188,9 @@ name = Yoni Bettan
> > face = ybettan.png
> > facewidth = 52
> > faceheight = 80
> > +
> > +[https://stefano-garzarella.github.io/posts/index.xml]
> > +name = Stefano Garzarella
> > +face = sgarzare.png
> > +facewidth = 89
> > +faceheight = 96
> > diff --git a/updater/virt-tools/images/sgarzare.png
b/updater/virt-tools/images/sgarzare.png
> > new file mode 100644
> > index 0000000..bf53f8a
> > Binary files /dev/null and b/updater/virt-tools/images/sgarzare.png differ
>
> You need to actually include the diff.....
Ooo... very sorry!
>
> I'm curious how you sent this, as I thought git send-email / git-publish
> just "do the right thing" in this respect ?
I used git-publish, I'll try to figure out what happened and I'll send a
v2 with the diff.
There is an issue in git-publish and '--no-binary' is always passed to git
format-patch, I'll send a PR to Stefan.
I'm sending a v2 with the binary diff.
Sorry again!
Cheers,
Stefano