9:40 p.m.
parted doesn't seem to want the label 'dos', instead
wanting 'msdos'. Patch is basically s/dos/msdos/
Thanks,
Cole
4:53 a.m.
Cole Robinson <crobinso(a)redhat.com> wrote:
parted doesn't seem to want the label 'dos', instead
wanting 'msdos'. Patch is basically s/dos/msdos/
Hi Cole,
This definitely needs to be fixed.
FYI, "dos" appears to be the preferred name for that partition table type
(google for "partition table" and either "dos" or "msdos";
also, partx
--type accepts "dos", not "msdos"). Too bad Parted added the
"ms" prefix.
If it's not hard to implement, it would be nice to hide the implementation
detail that Parted happens to call it the "msdos" label type.
diff --git a/docs/storage.html.in b/docs/storage.html.in
index 40e8e80..8cab480 100644
--- a/docs/storage.html.in
+++ b/docs/storage.html.in
@@ -258,7 +258,7 @@ libvirt.
</p>
<ul>
<li>
- <code>dos</code>
+ <code>msdos</code>
...
9:01 a.m.
Jim Meyering wrote:
Cole Robinson <crobinso(a)redhat.com> wrote:
> parted doesn't seem to want the label 'dos', instead
> wanting 'msdos'. Patch is basically s/dos/msdos/
Hi Cole,
This definitely needs to be fixed.
FYI, "dos" appears to be the preferred name for that partition table type
(google for "partition table" and either "dos" or "msdos";
also, partx
--type accepts "dos", not "msdos"). Too bad Parted added the
"ms" prefix.
If it's not hard to implement, it would be nice to hide the implementation
detail that Parted happens to call it the "msdos" label type.
We could just keep the outward facing label the same, and internally
map it to use msdos if calling 'parted mklabel' since it's the only
command that seems to use that value. Whatever people think is best.
Thanks,
Cole
5:12 a.m.
On Mon, Aug 11, 2008 at 10:01:16AM -0400, Cole Robinson wrote:
Jim Meyering wrote:
> Cole Robinson <crobinso(a)redhat.com> wrote:
>> parted doesn't seem to want the label 'dos', instead
>> wanting 'msdos'. Patch is basically s/dos/msdos/
>
> Hi Cole,
>
> This definitely needs to be fixed.
>
> FYI, "dos" appears to be the preferred name for that partition table type
> (google for "partition table" and either "dos" or
"msdos"; also, partx
> --type accepts "dos", not "msdos"). Too bad Parted added the
"ms" prefix.
> If it's not hard to implement, it would be nice to hide the implementation
> detail that Parted happens to call it the "msdos" label type.
>
We could just keep the outward facing label the same, and internally
map it to use msdos if calling 'parted mklabel' since it's the only
command that seems to use that value. Whatever people think is best.
Yep, I'd prefer that we just special case it internally when calling
out to mklabel.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
6:26 a.m.
On Tue, Aug 12, 2008 at 11:12:07AM +0100, Daniel P. Berrange wrote:
On Mon, Aug 11, 2008 at 10:01:16AM -0400, Cole Robinson wrote:
> Jim Meyering wrote:
> > Cole Robinson <crobinso(a)redhat.com> wrote:
> >> parted doesn't seem to want the label 'dos', instead
> >> wanting 'msdos'. Patch is basically s/dos/msdos/
> >
> > Hi Cole,
> >
> > This definitely needs to be fixed.
> >
> > FYI, "dos" appears to be the preferred name for that partition table
type
> > (google for "partition table" and either "dos" or
"msdos"; also, partx
> > --type accepts "dos", not "msdos"). Too bad Parted added
the "ms" prefix.
> > If it's not hard to implement, it would be nice to hide the implementation
> > detail that Parted happens to call it the "msdos" label type.
> >
>
> We could just keep the outward facing label the same, and internally
> map it to use msdos if calling 'parted mklabel' since it's the only
> command that seems to use that value. Whatever people think is best.
Yep, I'd prefer that we just special case it internally when calling
out to mklabel.
Fine by me, my only worry is that we are somehow breaking the storage XML
format as a result, but I don't think this is widely used at this point
(at least with MSDos) and best done earlier than later,
Applied and commited,
thanks !
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
10:58 p.m.
Daniel Veillard wrote:
On Tue, Aug 12, 2008 at 11:12:07AM +0100, Daniel P. Berrange wrote:
> On Mon, Aug 11, 2008 at 10:01:16AM -0400, Cole Robinson wrote:
>
>> Jim Meyering wrote:
>>
>>> Cole Robinson <crobinso(a)redhat.com> wrote:
>>>
>>>> parted doesn't seem to want the label 'dos', instead
>>>> wanting 'msdos'. Patch is basically s/dos/msdos/
>>>>
>>> Hi Cole,
>>>
>>> This definitely needs to be fixed.
>>>
>>> FYI, "dos" appears to be the preferred name for that partition
table type
>>> (google for "partition table" and either "dos" or
"msdos"; also, partx
>>> --type accepts "dos", not "msdos"). Too bad Parted added
the "ms" prefix.
>>> If it's not hard to implement, it would be nice to hide the
implementation
>>> detail that Parted happens to call it the "msdos" label type.
>>>
>>>
>> We could just keep the outward facing label the same, and internally
>> map it to use msdos if calling 'parted mklabel' since it's the only
>> command that seems to use that value. Whatever people think is best.
>>
> Yep, I'd prefer that we just special case it internally when calling
> out to mklabel.
>
Fine by me, my only worry is that we are somehow breaking the storage XML
format as a result, but I don't think this is widely used at this point
(at least with MSDos) and best done earlier than later,
Applied and commited,
thanks !
Daniel
Wait, I think there was a bit of miscommunication. I think Jim and Dan
were recommending
a different approach then the patch that was committed.
The attached patch keeps the public facing formats the same, we just
special case the dos
format to use "msdos" if calling out to parted (this would require the
current patch to be
reverted though).
Dan, is this what you meant?
Thanks,
Cole
4:46 a.m.
On Tue, Aug 12, 2008 at 11:58:12PM -0400, Cole Robinson wrote:
Daniel Veillard wrote:
> Fine by me, my only worry is that we are somehow breaking the storage XML
> format as a result, but I don't think this is widely used at this point
> (at least with MSDos) and best done earlier than later,
>
> Applied and commited,
>
> thanks !
>
> Daniel
>
Wait, I think there was a bit of miscommunication. I think Jim and Dan
were recommending
a different approach then the patch that was committed.
The attached patch keeps the public facing formats the same, we just
special case the dos
format to use "msdos" if calling out to parted (this would require the
current patch to be
reverted though).
Okay, I think I'm the one who misunderstood, so reverted and applied the
new fix which only change at the parted call level.
Sorry :-)
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
5945
days inactive
5947
days old
6 comments
4 participants
participants (4)
-
Cole Robinson -
Daniel P. Berrange -
Daniel Veillard -
Jim Meyering