1:26 a.m.
Andrea Bolognani (2):
AUTHORS: Remove unnecessary remark
AUTHORS: Indent list of contributors
AUTHORS.in | 2 --
Makefile.am | 3 ++-
2 files changed, 2 insertions(+), 3 deletions(-)
--
2.17.1
1:26 a.m.
New subject: [libvirt] [dbus PATCH 1/2] AUTHORS: Remove unnecessary remark
While technically correct (you have to send patches for
your name to appear on the list) the remark, which was
lifted from libvirt, was clearly intended for a time
before AUTHORS was partially generated from the git log.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
AUTHORS.in | 2 --
1 file changed, 2 deletions(-)
diff --git a/AUTHORS.in b/AUTHORS.in
index a2b2a2d..12e66e1 100644
--- a/AUTHORS.in
+++ b/AUTHORS.in
@@ -14,5 +14,3 @@ The primary maintainers of libvirt-dbus are:
Patches have been received from:
#authorslist#
-
- ... send patches to get your name added ...
--
2.17.1
1:26 a.m.
New subject: [libvirt] [dbus PATCH 2/2] AUTHORS: Indent list of contributors
The list of maintainers is already indented, so doing the
same (programmatically) for the list of contributors as
well makes the result quite a bit nicer.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
Makefile.am | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 8abba68..f5fd8d7 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -29,7 +29,8 @@ dist-hook: gen-AUTHORS
.PHONY: gen-AUTHORS
gen-AUTHORS:
$(AM_V_GEN)if test -d $(srcdir)/.git; then \
- out="`cd $(srcdir) && git log --pretty=format:'%aN <%aE>' |
sort -u`" && \
+ out="`cd $(srcdir) && git log --pretty=format:'%aN
<%aE>'`" && \
+ out="`echo "$$out" | sort -u | sed 's/^/ /g'`"
&& \
perl -p -e "s/#authorslist#// and print '$$out'" \
< $(srcdir)/AUTHORS.in > $(distdir)/AUTHORS-tmp && \
mv -f $(distdir)/AUTHORS-tmp $(distdir)/AUTHORS ; \
--
2.17.1
1:50 a.m.
New subject: [libvirt] [dbus PATCH 2/2] AUTHORS: Indent list of contributors
On Wed, Jul 04, 2018 at 08:26:17AM +0200, Andrea Bolognani wrote:
The list of maintainers is already indented, so doing the
same (programmatically) for the list of contributors as
well makes the result quite a bit nicer.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
Makefile.am | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 8abba68..f5fd8d7 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -29,7 +29,8 @@ dist-hook: gen-AUTHORS
.PHONY: gen-AUTHORS
gen-AUTHORS:
$(AM_V_GEN)if test -d $(srcdir)/.git; then \
- out="`cd $(srcdir) && git log --pretty=format:'%aN <%aE>'
| sort -u`" && \
+ out="`cd $(srcdir) && git log --pretty=format:'%aN
<%aE>'`" && \
+ out="`echo "$$out" | sort -u | sed 's/^/ /g'`"
&& \
Instead of the 'sed' command you can put the indentation into the
'format':
format:' %aN <%aE>'
Pavel
2:11 a.m.
New subject: [libvirt] [dbus PATCH 2/2] AUTHORS: Indent list of contributors
On Wed, 2018-07-04 at 08:50 +0200, Pavel Hrdina wrote:
On Wed, Jul 04, 2018 at 08:26:17AM +0200, Andrea Bolognani wrote:
> gen-AUTHORS:
> $(AM_V_GEN)if test -d $(srcdir)/.git; then \
> - out="`cd $(srcdir) && git log --pretty=format:'%aN
<%aE>' | sort -u`" && \
> + out="`cd $(srcdir) && git log --pretty=format:'%aN
<%aE>'`" && \
> + out="`echo "$$out" | sort -u | sed 's/^/ /g'`"
&& \
Instead of the 'sed' command you can put the indentation into the
'format':
format:' %aN <%aE>'
Good call! Fixed and pushed.
--
Andrea Bolognani / Red Hat / Virtualization
2333
days inactive
2333
days old
5 comments
2 participants
participants (2)
-
Andrea Bolognani -
Pavel Hrdina