[libvirt] : [Bug 993411] Compilation fails on lxc/lxc_monitor_protocol.c 31: undefined reference to xdr_uinit64_t
4:19 p.m.
suggested patch for compilation issue.
--- lxc_monitor_protocol.h 2013-08-05 20:22:23.963000000 +0000
+++ libvirt-1.1.1/src/lxc/lxc_monitor_protocol.h 2013-08-05 20:22:46.226000000
+0000
@@ -5,6 +5,8 @@
#ifndef _LXC_MONITOR_PROTOCOL_H_RPCGEN
#define _LXC_MONITOR_PROTOCOL_H_RPCGEN
+# define xdr_uint64_t xdr_u_int64_t
+
#include <rpc/rpc.h>
-----Original Message-----
From: bugzilla(a)redhat.com [mailto:bugzilla@redhat.com]
Sent: Monday, August 05, 2013 4:15 PM
To: Gerald Palmer
Subject: [Bug 993411] Compilation fails on lxc/lxc_monitor_protocol.c 31: undefined
reference to xdr_uinit64_t
https://bugzilla.redhat.com/show_bug.cgi?id=993411
Eric Blake <eblake(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |eblake(a)redhat.com,
| |gpalmer(a)lganet.com
Flags| |needinfo?(gpalmer(a)lganet.co
| |m)
--- Comment #1 from Eric Blake <eblake(a)redhat.com> --- Can you please post this
patch upstream at libvir-list(a)redhat.com for discussion?
--
You are receiving this mail because:
You are on the CC list for the bug.
You reported the bug.
4:27 a.m.
On Mon, Aug 05, 2013 at 04:19:54PM -0500, Gerald Palmer wrote:
suggested patch for compilation issue.
--- lxc_monitor_protocol.h 2013-08-05 20:22:23.963000000 +0000
+++ libvirt-1.1.1/src/lxc/lxc_monitor_protocol.h 2013-08-05 20:22:46.226000000
+0000
@@ -5,6 +5,8 @@
#ifndef _LXC_MONITOR_PROTOCOL_H_RPCGEN
#define _LXC_MONITOR_PROTOCOL_H_RPCGEN
+# define xdr_uint64_t xdr_u_int64_t
+
What platform are you compiling on ?
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
8:57 a.m.
On 08/06/2013 03:27 AM, Daniel P. Berrange wrote:
On Mon, Aug 05, 2013 at 04:19:54PM -0500, Gerald Palmer wrote:
>
> suggested patch for compilation issue.
> --- lxc_monitor_protocol.h 2013-08-05 20:22:23.963000000 +0000
> +++ libvirt-1.1.1/src/lxc/lxc_monitor_protocol.h 2013-08-05 20:22:46.226000000
+0000
This is a generated file. Changes made here will be lost when the file
is regenerated. We need to move the change into the source, which is
lxc/lxc_monitor_protocol.x.
> @@ -5,6 +5,8 @@
>
> #ifndef _LXC_MONITOR_PROTOCOL_H_RPCGEN
> #define _LXC_MONITOR_PROTOCOL_H_RPCGEN
> +# define xdr_uint64_t xdr_u_int64_t
> +
What platform are you compiling on ?
And should we fix this for ALL the protocols at once? It looks like
this snippet from src/remote/remote_protocol.x is more likely to be
correct; but if that's the case, we should hoist it into
src/rpc/genprotocol.pl to happen for ALL .x files rather than copying
and pasting it everywhere.
/* cygwin's xdr implementation defines xdr_u_int64_t instead of xdr_uint64_t
* and lacks IXDR_PUT_INT32 and IXDR_GET_INT32
*/
%#ifdef HAVE_XDR_U_INT64_T
%# define xdr_uint64_t xdr_u_int64_t
%#endif
%#ifndef IXDR_PUT_INT32
%# define IXDR_PUT_INT32 IXDR_PUT_LONG
%#endif
%#ifndef IXDR_GET_INT32
%# define IXDR_GET_INT32 IXDR_GET_LONG
%#endif
%#ifndef IXDR_PUT_U_INT32
%# define IXDR_PUT_U_INT32 IXDR_PUT_U_LONG
%#endif
%#ifndef IXDR_GET_U_INT32
%# define IXDR_GET_U_INT32 IXDR_GET_U_LONG
%#endif
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
9:47 a.m.
Linux localhost.localnet 3.8.1 #1 SMP Sun Jul 21 16:11:57 GMT 2013 x86_64 GNU/Linux
bc-1.06
zlib-1.2.5
openssl-1.0.0a
openssh-5.5p1
# gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-unknown-linux-gnu/4.7.2/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: ../gcc-4.7.2/configure --prefix=/usr --libexecdir=/usr/lib
--enable-shared --enable-threads=posix --enable-__cxa_atexit --enable-clocale=gnu
--enable-languages=c,c++ --disable-multilib --disable-bootstrap --with-system-zlib
Thread model: posix
gcc version 4.7.2 (GCC)
this is the definition which existes in the following files:
remote/remote_protocol.c
remote/remote_protocol.h
rpc/virnetprotocol.c
rpc/virnetprotocol.h
-----Original Message-----
From: Daniel P. Berrange [mailto:berrange@redhat.com]
Sent: Tuesday, August 06, 2013 4:27 AM
To: Gerald Palmer
Cc: 'libvir-list(a)redhat.com'
Subject: Re: [libvirt] : [Bug 993411] Compilation fails on lxc/lxc_monitor_protocol.c 31:
undefined reference to xdr_uinit64_t
On Mon, Aug 05, 2013 at 04:19:54PM -0500, Gerald Palmer wrote:
suggested patch for compilation issue.
--- lxc_monitor_protocol.h 2013-08-05 20:22:23.963000000 +0000
+++ libvirt-1.1.1/src/lxc/lxc_monitor_protocol.h 2013-08-05 20:22:46.226000000
+0000
@@ -5,6 +5,8 @@
#ifndef _LXC_MONITOR_PROTOCOL_H_RPCGEN #define
_LXC_MONITOR_PROTOCOL_H_RPCGEN
+# define xdr_uint64_t xdr_u_int64_t
+
What platform are you compiling on ?
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
4160
days inactive
4161
days old
3 comments
3 participants
participants (3)
-
Daniel P. Berrange -
Eric Blake -
Gerald Palmer