Note that I had to drop the 'noreply.github.com' email address. Please don't use that as the author credential as it makes hard to reply properly to threads. On Mon, Mar 11, 2024 at 02:15:32 +0200, Mostafa wrote: Per contributor guidelines: Contributors to libvirt projects must assert that they are in compliance with the Developer Certificate of Origin 1.1. This is achieved by adding a "Signed-off-by" line containing the contributor's name and e-mail to every commit message. The presence of this line attests that the contributor has read the above lined DCO and agrees with its statements. https://www.libvirt.org/hacking.html#developer-certificate-of-origin Please make sure to follow all points of that document, especially all paragraphs about: https://www.libvirt.org/hacking.html#preparing-patches in future postings. After this patch the code fails to compile: In function ‘g_autoptr_cleanup_generic_gfree’, inlined from ‘virDomainSave’ at ../../../libvirt/src/libvirt-domain.c:887:2 : /usr/include/glib-2.0/glib/glib-autocleanups.h:30:3: error: ‘absolute_to’ may be used uninitialized [-Werror=maybe-uninitialized] 30 | g_free (*pp); | ^~~~~~~~~~~~ ../../../libvirt/src/libvirt-domain.c: In function ‘virDomainSave’: ../../../libvirt/src/libvirt-domain.c:887:26: note: ‘absolute_to’ was declared here 887 | g_autofree char *absolute_to; | ^~~~~~~~~~~ In function ‘g_autoptr_cleanup_generic_gfree’, inlined from ‘virDomainSaveFlags’ at ../../../libvirt/src/libvirt-domain.c:975:26: /usr/include/glib-2.0/glib/glib-autocleanups.h:30:3: error: ‘absolute_to’ may be used uninitialized [-Werror=maybe-uninitialized] 30 | g_free (*pp); | ^~~~~~~~~~~~ When compiling the code by default from a git checkout we enable all errors thus you should be getting this error or the syntax-check error for the same thing if you have an older compiler. Make sure to both compile and run tests as the contributor guidelines state.