7:15 a.m.
So far we are checking if qemu supports 'nbd-server-start'. This,
however, makes no sense on the source as nbd-server-* is used on the
destination. On the source the 'drive-mirror' is used instead.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/qemu/qemu_migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 7d8b727..166fbb9 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -1987,7 +1987,7 @@ static char
goto cleanup;
if (flags & (VIR_MIGRATE_NON_SHARED_DISK | VIR_MIGRATE_NON_SHARED_INC)
&&
- virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_NBD_SERVER)) {
+ virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DRIVE_MIRROR)) {
/* TODO support NBD for TUNNELLED migration */
if (flags & VIR_MIGRATE_TUNNELLED) {
VIR_WARN("NBD in tunnelled migration is currently not supported");
--
1.8.1.5
7:20 a.m.
On 11/07/2013 06:15 AM, Michal Privoznik wrote:
So far we are checking if qemu supports 'nbd-server-start'.
This,
however, makes no sense on the source as nbd-server-* is used on the
destination. On the source the 'drive-mirror' is used instead.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/qemu/qemu_migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ACK.
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 7d8b727..166fbb9 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -1987,7 +1987,7 @@ static char
goto cleanup;
if (flags & (VIR_MIGRATE_NON_SHARED_DISK | VIR_MIGRATE_NON_SHARED_INC)
&&
- virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_NBD_SERVER)) {
+ virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DRIVE_MIRROR)) {
/* TODO support NBD for TUNNELLED migration */
if (flags & VIR_MIGRATE_TUNNELLED) {
VIR_WARN("NBD in tunnelled migration is currently not
supported");
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
7:26 a.m.
On Thu, Nov 07, 2013 at 06:20:22 -0700, Eric Blake wrote:
On 11/07/2013 06:15 AM, Michal Privoznik wrote:
> So far we are checking if qemu supports 'nbd-server-start'. This,
> however, makes no sense on the source as nbd-server-* is used on the
> destination. On the source the 'drive-mirror' is used instead.
>
> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
> ---
> src/qemu/qemu_migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
ACK.
The only thing I'm worried about is whether we need to check if
drive-mirror actually supports streaming data to the NBD server. Was it
always supported by drive-mirror or was it added later?
Jirka
7:30 a.m.
On 07.11.2013 14:26, Jiri Denemark wrote:
On Thu, Nov 07, 2013 at 06:20:22 -0700, Eric Blake wrote:
> On 11/07/2013 06:15 AM, Michal Privoznik wrote:
>> So far we are checking if qemu supports 'nbd-server-start'. This,
>> however, makes no sense on the source as nbd-server-* is used on the
>> destination. On the source the 'drive-mirror' is used instead.
>>
>> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
>> ---
>> src/qemu/qemu_migration.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> ACK.
The only thing I'm worried about is whether we need to check if
drive-mirror actually supports streaming data to the NBD server. Was it
always supported by drive-mirror or was it added later?
Well, both nbd-server-start and drive-mirror were added in the same 1.3
release so I expect drive-mirror to support streaming to NBD.
Michal
4035
days inactive
4035
days old
3 comments
3 participants
participants (3)
-
Eric Blake -
Jiri Denemark -
Michal Privoznik