10:56 a.m.
From: Guan Qiang <hzguanqiang(a)corp.netease.com>
The patches add support for setting/getting blkio read/write bps/iops
throttle per-device with blkio cgroup.
Guan Qiang (2):
blkiotune: add support for device iops and bps throttle
blkiotune: add virsh support for blkiotune.throttle.iops/bps
docs/formatdomain.html.in | 8 +
docs/schemas/domaincommon.rng | 28 +-
include/libvirt/libvirt.h.in | 40 ++
src/conf/domain_conf.c | 115 +++-
src/conf/domain_conf.h | 16 +-
src/libvirt_private.syms | 4 +-
src/lxc/lxc_cgroup.c | 9 +-
src/qemu/qemu_cgroup.c | 10 +-
src/qemu/qemu_driver.c | 579 ++++++++++++++++++--
src/util/vircgroup.c | 79 ++-
src/util/vircgroup.h | 8 +-
.../qemuxml2argv-blkiotune-device.xml | 4 +
tools/virsh-domain.c | 64 +++
tools/virsh.pod | 32 +-
14 files changed, 883 insertions(+), 113 deletions(-)
--
1.7.9.5
11:12 a.m.
On 09/17/2013 09:56 AM, hzguanqiang(a)gmail.com wrote:
From: Guan Qiang <hzguanqiang(a)corp.netease.com>
The patches add support for setting/getting blkio read/write bps/iops
throttle per-device with blkio cgroup.
Closer. This time, your cover letter lists:
Message-id: <52387bc4.8223440a.6e6a.163b(a)mx.google.com>
which is valid; but your patches list:
References: <1379433398-21795-1-git-send-email-y>
In-Reply-To: <1379433398-21795-1-git-send-email-y>
which is still not a valid email reference (according to the RFCs,
References: and In-Reply-To: fields should contain an @), and therefore
are not threaded to the cover letter.
Note how confused the list archiver got when trying to decipher your mail:
https://www.redhat.com/archives/libvir-list/2013-September/thread.html#01007
For an example of threading done right, see:
https://www.redhat.com/archives/libvir-list/2013-September/thread.html#00982
There, the cover letter uses:
Message-id: <cover.1379428840.git.mprivozn(a)redhat.com>
and each patch contains:
References: <cover.1379428840.git.mprivozn(a)redhat.com>
In-Reply-To: <cover.1379428840.git.mprivozn(a)redhat.com>
When working on git mail configurations, it is often a good idea to use
'git send-email --to=YOUR@EMAIL' and send the patches to yourself first,
to check if you have properly configured git, before sending to the list.
At any rate, please don't resend just because of this (3 attempts is
enough for one day; the patches are available, even if we have to hunt a
bit for them); just remember it for you next future patch submission :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
1:57 a.m.
New subject: [libvirt] Some Questiones about patch submission and libvirt development workflow.
Hi Eric,
On 2013-09-18 00:12 , Eric Blake wrote:
On 09/17/2013 09:56 AM, hzguanqiang(a)gmail.com wrote:
From: Guan Qiang <hzguanqiang(a)corp.netease.com>
The patches add support for setting/getting blkio read/write bps/iops
throttle per-device with blkio cgroup.
Closer. This time, your cover letter lists:
Message-id: <52387bc4.8223440a.6e6a.163b(a)mx.google.com>
which is valid; but your patches list:
References: <1379433398-21795-1-git-send-email-y>
In-Reply-To: <1379433398-21795-1-git-send-email-y>
which is still not a valid email reference (according to the RFCs,
References: and In-Reply-To: fields should contain an @), and therefore
are not threaded to the cover letter.
Note how confused the list archiver got when trying to decipher your mail:
https://www.redhat.com/archives/libvir-list/2013-September/thread.html#01007
For an example of threading done right, see:
https://www.redhat.com/archives/libvir-list/2013-September/thread.html#00982
There, the cover letter uses:
Message-id: <cover.1379428840.git.mprivozn(a)redhat.com>
and each patch contains:
References: <cover.1379428840.git.mprivozn(a)redhat.com>
In-Reply-To: <cover.1379428840.git.mprivozn(a)redhat.com>
When working on git mail configurations, it is often a good idea to use
'git send-email --to=YOUR@EMAIL' and send the patches to yourself first,
to check if you have properly configured git, before sending to the list.
At any rate, please don't resend just because of this (3 attempts is
enough for one day; the patches are available, even if we have to hunt a
bit for them); just remember it for you next future patch submission :)
I've tried to send the patches to my own email before I send-email to libvir-list.
But How do I confirm it's ok? Make sure the patch series with the same
Message-id, References and In-Reply-To info?
And What're the whole libvirt development workflow? After I submit a patch,
What will happen following? Is there anyone assigned to review it? If modification need
to be made for the patches, should submitter send new patch email? Or If the patch is not
so interested, will it be ignored? And what's the requirement for a patch to be signed
off?
Thanks
------------------
Best regards!
GuanQiang
14:30:25
4085
days inactive
4086
days old
2 comments
3 participants
participants (3)
-
Eric Blake -
hzguanqiang＠corp.netease.com -
hzguanqiang＠gmail.com