12:39 p.m.
Hi,
libvirt segfaults for me when run in the foreground and pressing ctrl-c.
A bisect of the code lead me to this commit
commit 7c1119e3bbd483c52ae4cdfebe23dd179ad28124
Author: Daniel P. Berrange <berrange(a)redhat.com>
Date: Tue Aug 7 12:02:06 2012 +0100
Stefan
2 p.m.
On 08/08/2012 11:39 AM, Stefan Berger wrote:
Hi,
libvirt segfaults for me when run in the foreground and pressing ctrl-c.
Do you mean 'libvirtd', when run manually? Or virsh?
A bisect of the code lead me to this commit
commit 7c1119e3bbd483c52ae4cdfebe23dd179ad28124
Author: Daniel P. Berrange <berrange(a)redhat.com>
Date: Tue Aug 7 12:02:06 2012 +0100
Set LIBVIRT_AUTOSTART=0 when running test suites
I don't see how that patch can affect libvirtd, since it only touched
tests/Makefile.am and has no impact on libvirtd itself.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
2:35 p.m.
On 08/08/2012 03:00 PM, Eric Blake wrote:
On 08/08/2012 11:39 AM, Stefan Berger wrote:
> Hi,
>
> libvirt segfaults for me when run in the foreground and pressing ctrl-c.
Do you mean 'libvirtd', when run manually? Or virsh?
It's libvirtd when run from the shell via /usr/sbin/libvirtd
Yes, the bisect lead to an odd result. Will need to repeat.
Stefan
2:45 p.m.
On 08/08/2012 03:00 PM, Eric Blake wrote:
Set LIBVIRT_AUTOSTART=0 when running test suites I don't see how
that
patch can affect libvirtd, since it only touched tests/Makefile.am and
has no impact on libvirtd itself.
Indeed, the problem happens here:
commit 958499b0c12072e36d20effeddf4a400d9919bb8
Author: Daniel P. Berrange <berrange(a)redhat.com>
Date: Wed Jul 11 14:35:52 2012 +0100
Regards,
Stefan
2:48 p.m.
On 08/08/2012 01:45 PM, Stefan Berger wrote:
On 08/08/2012 03:00 PM, Eric Blake wrote:
> Set LIBVIRT_AUTOSTART=0 when running test suites I don't see how that
> patch can affect libvirtd, since it only touched tests/Makefile.am and
> has no impact on libvirtd itself.
Indeed, the problem happens here:
commit 958499b0c12072e36d20effeddf4a400d9919bb8
Author: Daniel P. Berrange <berrange(a)redhat.com>
Date: Wed Jul 11 14:35:52 2012 +0100
In which case, it is probably fixed here:
commit 411859278650b331fa4f06d52bee0aa8c0001ce5
Author: Guannan Ren <gren(a)redhat.com>
Date: Wed Aug 8 17:32:22 2012 +0800
rpc: fix a virObject typo error in struct _virNetServer
This typo will crash libvirtd when it recevies signal SIGINT
diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c
index a1ea038..15abb56 100644
--- a/src/rpc/virnetserver.c
+++ b/src/rpc/virnetserver.c
@@ -64,7 +64,7 @@ struct _virNetServerJob {
};
struct _virNetServer {
- virObjectPtr object;
+ virObject object;
virMutex lock;
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
4:25 a.m.
On Wed, Aug 08, 2012 at 01:48:38PM -0600, Eric Blake wrote:
On 08/08/2012 01:45 PM, Stefan Berger wrote:
> On 08/08/2012 03:00 PM, Eric Blake wrote:
>> Set LIBVIRT_AUTOSTART=0 when running test suites I don't see how that
>> patch can affect libvirtd, since it only touched tests/Makefile.am and
>> has no impact on libvirtd itself.
> Indeed, the problem happens here:
>
> commit 958499b0c12072e36d20effeddf4a400d9919bb8
> Author: Daniel P. Berrange <berrange(a)redhat.com>
> Date: Wed Jul 11 14:35:52 2012 +0100
In which case, it is probably fixed here:
commit 411859278650b331fa4f06d52bee0aa8c0001ce5
Author: Guannan Ren <gren(a)redhat.com>
Date: Wed Aug 8 17:32:22 2012 +0800
rpc: fix a virObject typo error in struct _virNetServer
This typo will crash libvirtd when it recevies signal SIGINT
Yep, this should fix the SEGV, I could reproduce it
myself too
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
4488
days inactive
4489
days old
5 comments
3 participants
participants (3)
-
Daniel P. Berrange -
Eric Blake -
Stefan Berger