On Mon, Oct 18, 2010 at 02:41:26PM +0200, arnaud.champion(a)devatom.fr wrote: > ?Hi, Hi Arnaud, > this is my first patch import for libvirt C# bindings. Sorry I > haven't been able to change the mime type for the patch (Windows > Mail doesn't allow this it seems) Okay, I can't really test this, but I have a few comments: - Properties/AssemblyInfo.cs has comments in french, I could try to translate them, probably not urgent, and seems like directive on how to generate the binary for C#, so not very urgent - Since the COPYING.LIB in the current git is LGPLv2+ and since it's referenced, I assume that's the licence intended for this contribution - in Properties/AssemblyInfo.cs I see references to Microsoft and especially "Copyright © Microsoft 2010" do we really want to do this ? - for each entry point I see [DllImport("libvirt-0.dll")] public static extern .... I have 2 questions: - should the DllImport be factored in some ways or is that just a C# construct interpreted just at compile time - assuming we want to add Mono compatibility it seems the library would be named differently on a Linux system, is there a way to at least factor out the string of the library being imported (maybe in an initialization routine ?) Anyway, since the git tree was currently empty (except for Licence files) I commited and pushed the patch (just cleaned up a few trailing whitespaces). It's there now http://libvirt.org/git/?p=libvirt-csharp.git So the best from now on is to provide patches against git, I suggest to use this list for further discussions and patches as we do for Java, thanks a lot ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

On 10/19/2010 12:25 AM, Daniel Veillard wrote: <snip> > Anyway, since the git tree was currently empty (except for Licence > files) I commited and pushed the patch (just cleaned up a few trailing > whitespaces). It's there now > http://libvirt.org/git/?p=libvirt-csharp.git Are the C# bindings there "ok" for people to use? Should be update the documentation page to point to them? + Justin

On 10/19/2010 02:29 AM, arnaud.champion(a)devatom.fr wrote: > ?Hi justin, > > here is a xls that I use to keep advance of bindings. Nice. :) Converted it into HTML, for adding to the libvirt documentation. Here is what it looks like: http://justinclift.fedorapeople.org/csharp/csharp.html Does anything there need changing, before this page is added to the proper libvirt website? Regards and best wishes, Justin Clift

?Wow it's very nice :) Just one thing you had to know, I plan to add sample code of using libvirt bindings, so in the future, I will add a column to indicate the sample code snippet for each function et bindings.

Arnaud

The class library expose the "LibvirtBindings" namespace. This namespace expose all needed types (enum, struct). It also expose 2 main classes : "libVirt" and "libvirtError". The "libVirt" class expose all  interfaces of the libvirt library to handle virtualized domains and "libvirtError" class expose all interfaces of the libvirt library to handle errors raised while using the library.

The idea was to stick to libvirt API documentation which contain a libvirt part and a virError part. Types are used everywhere that's why they are at a upper level (LibvirtBindings). In fact, libVirt and libvirtError are in the LibvirtBindings, as they are classes. This is useful to clean the code and not have all the code in one class... But I don't know what is better, usually, in this kind of project, I'm used to separate things.

On Tue, Oct 19, 2010 at 05:43:50PM +0200, Matthias Bolte wrote: > 2010/10/18 <arnaud.champion(a)devatom.fr&gt;: > > The class library expose the "LibvirtBindings" namespace. This > > namespace > > expose all needed types (enum, struct). It also expose 2 main classes : > > "libVirt" and "libvirtError". The "libVirt" class expose all > > interfaces of > > the libvirt library to handle virtualized domains and "libvirtError" > > class > > expose all interfaces of the libvirt library to handle errors raised > > while > > using the library. > > Is there a specific reason to use three different ways to capitalize > libvirt in the C# code? > > LibvirtBindings > libVirt > libvirtError > > I suggest you choose one form and stick with it, for example > > LibvirtBindings > Libvirt > LibvirtError Personally I'd make the naming look much more like the Java bindings. Instead of following the C naming directly which is fugly for non-C languages, have a 'libvirt' namespace, and then use plain names like 'Connect', 'Domain', 'Network' for the objects and strip the prefix off the method names to 'Connect.open', 'Domain.dump_xml' etc Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

?Hi justin, here is a xls that I use to keep advance of bindings.

?You are right, my mistake :) You'll find an update version attached to this mail. There is some new columns in the xls. "Sample Code" refer the name of the sample code project (the name is the same for Mono on .Net) "Test .Net/Windows Works" indicate the test state under .Net/Windows "Test Mono/Windows Works" indicate the test state under Mono/Windows "Test Mono/Windows Works" indicate the test state under Mono/Linux The joined xls assume the patch I have just sended to the list. For information, tests under windows are done under Windows 7 with .Net 4 and Visual Studio 2010 and MonoDevelop 2.4. Tests under linux are done under Fedora 13 i686 and MonoDevelop 2.2

Arnaud

?You are right, my mistake :) You'll find an update version attached to this mail. There is some new columns in the xls.

> Ok, how's this? > > http://justinclift.fedorapeople.org/csharp/csharp.html Can we also include a sample program using the bindings, as is done in http://justinclift.fedorapeople.org/csharp/python.html and http://justinclift.fedorapeople.org/csharp/java.html?

On 10/20/2010 05:08 AM, Justin Clift wrote: > On 10/20/2010 04:57 AM, Eric Blake wrote: > <snip> >>> Ok, how's this? >>> >>> http://justinclift.fedorapeople.org/csharp/csharp.html >> >> Can we also include a sample program using the bindings, as is done in >> http://justinclift.fedorapeople.org/csharp/python.html and >> http://justinclift.fedorapeople.org/csharp/java.html? > > Good idea. Just added a space for one in the layout. > > Arnaud, would I be able to get an example program from you, for adding > there? Is "virConnectOpenAuth" the correct kind of thing? Looked at the virConnectOpenAuth example (from Arnauds patches waiting for review). It doesn't seem like a suitable example for the web page, as the example code is a lot longer/larger than we'd like for this. Arnaud, do you have time to create an extremely simple example? Something that shows the very minimum needed. Sort of like this: (I do not know C# at all though :>) using System; using LibvirtBindings; // Fill a virConnectAuth structure virConnectAuth auth = new virConnectAuth { cbdata = authData, // The authData structure cb = AuthCallback, // the method called by callbacks CredTypes = new[] { // The list of credentials types virConnectCredentialType.VIR_CRED_AUTHNAME, virConnectCredentialType.VIR_CRED_PASSPHRASE } }; // Request the connection IntPtr conn = libVirt.virConnectOpenAuth(tbURI.Text, ref auth, 0); // Get the pointer to the domain string domainName = new string "MyGuest"; IntPtr domainPtr = libVirt.virDomainLookupByName(conn, domainName); // Start the domain Int something = libVirt.virDomainCreate(domainPtr); // Close the connection libVirt.virConnectClose(conn); ? Regards and best wishes, Justin Clift

?Well, I can make a little sample, with virConnectOpen instead of virConnectOpenAuth, because virConnectOpenAuth cannot work without callback handling, that's why it's larger. But I will be tomorrow ;) it's time to sleep for me. -------------------------------------------------- From: "Justin Clift" <jclift(a)redhat.com&gt; Sent: Tuesday, October 19, 2010 9:46 PM To: "Arnaud Champion" <arnaud.champion(a)devatom.fr&gt; Cc: "Libvirt Developers Mailing List" <libvir-list(a)redhat.com&gt; Subject: Re: [libvirt] C# bindings (Was: First patch) > On 10/20/2010 05:08 AM, Justin Clift wrote: >> On 10/20/2010 04:57 AM, Eric Blake wrote: >> <snip> >>>> Ok, how's this? >>>> >>>> http://justinclift.fedorapeople.org/csharp/csharp.html >>> >>> Can we also include a sample program using the bindings, as is done in >>> http://justinclift.fedorapeople.org/csharp/python.html and >>> http://justinclift.fedorapeople.org/csharp/java.html? >> >> Good idea. Just added a space for one in the layout. >> >> Arnaud, would I be able to get an example program from you, for adding >> there? Is "virConnectOpenAuth" the correct kind of thing? > > Looked at the virConnectOpenAuth example (from Arnauds patches waiting > for review). It doesn't seem like a suitable example for the web page, > as the example code is a lot longer/larger than we'd like for this. > > Arnaud, do you have time to create an extremely simple example? > > Something that shows the very minimum needed. Sort of like this: > (I do not know C# at all though :>) > > using System; > using LibvirtBindings; > > // Fill a virConnectAuth structure > virConnectAuth auth = new virConnectAuth > { > cbdata = authData, // The authData structure > cb = AuthCallback, // the method called by callbacks > CredTypes = new[] > { > // The list of credentials types > virConnectCredentialType.VIR_CRED_AUTHNAME, > virConnectCredentialType.VIR_CRED_PASSPHRASE > } > }; > > // Request the connection > IntPtr conn = libVirt.virConnectOpenAuth(tbURI.Text, ref auth, 0); > > // Get the pointer to the domain > string domainName = new string "MyGuest"; > IntPtr domainPtr = libVirt.virDomainLookupByName(conn, domainName); > > // Start the domain > Int something = libVirt.virDomainCreate(domainPtr); > > // Close the connection > libVirt.virConnectClose(conn); > > ? > > Regards and best wishes, > > Justin Clift > -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

On 10/20/2010 01:32 AM, arnaud.champion(a)devatom.fr wrote: > ?You are right, my mistake :) > > You'll find an update version attached to this mail. > > There is some new columns in the xls. Ok, how's this? http://justinclift.fedorapeople.org/csharp/csharp.html