At the beginning of vmx.c we have a comment that maps virtualHW.version field onto ESX version. However, it wasn't updated in a while. Fill it in using the following kbase article: https://kb.vmware.com/s/article/1003746 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; --- src/vmx/vmx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 04eabff18a..c3c00a5c7e 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -48,6 +48,10 @@ domain-xml <=> vmx virtualHW.version = "8" # essential for ESX 5.0 virtualHW.version = "9" # essential for ESX 5.1 virtualHW.version = "10" # essential for ESX 5.5 + virtualHW.version = "11" # essential for ESX 6.0 + virtualHW.version = "13" # essential for ESX 6.5 + virtualHW.version = "14" # essential for ESX 6.7 + virtualHW.version = "17" # essential for ESX 7.0 ??? <=> guestOS = "<value>" # essential, FIXME: not representable -- 2.31.1

The way we parse VMX configuration is rather unfortunate, especially when it comes to disks. We allocate an array that can handle all possible disks but leave the array counter (ndisks) at zero and increase it only after successful parsing. But, we never size the array down to release unneeded chunks of memory. We can do better: we can use VIR_APPEND_ELEMENT() to allocate array as needed. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; --- src/vmx/vmx.c | 84 ++++++++++++++++++++++++++------------------------- 1 file changed, 43 insertions(+), 41 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index c3c00a5c7e..7a934e067d 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -1719,10 +1719,6 @@ virVMXParseConfig(virVMXContext *ctx, if (def->graphics[def->ngraphics] != NULL) ++def->ngraphics; - /* def:disks: 4 * 15 scsi + 4 * 30 sata + 2 * 2 ide + 2 floppy = 186 */ - def->disks = g_new0(virDomainDiskDef *, 186); - def->ndisks = 0; - /* def:disks (scsi) */ for (controller = 0; controller < 4; ++controller) { if (virVMXParseSCSIController(conf, controller, &present, @@ -1734,6 +1730,8 @@ virVMXParseConfig(virVMXContext *ctx, continue; for (unit = 0; unit < 16; ++unit) { + g_autoptr(virDomainDiskDef) disk = NULL; + if (unit == 7) { /* * SCSI unit 7 is assigned to the SCSI controller and cannot be @@ -1744,25 +1742,23 @@ virVMXParseConfig(virVMXContext *ctx, if (virVMXParseDisk(ctx, xmlopt, conf, VIR_DOMAIN_DISK_DEVICE_DISK, VIR_DOMAIN_DISK_BUS_SCSI, controller, unit, - &def->disks[def->ndisks], def) < 0) { + &disk, def) < 0) { goto cleanup; } - if (def->disks[def->ndisks] != NULL) { - ++def->ndisks; + if (!disk && + virVMXParseDisk(ctx, xmlopt, conf, VIR_DOMAIN_DISK_DEVICE_CDROM, + VIR_DOMAIN_DISK_BUS_SCSI, controller, unit, + &disk, def) < 0) { + goto cleanup; + } + + if (!disk) continue; - } - if (virVMXParseDisk(ctx, xmlopt, conf, VIR_DOMAIN_DISK_DEVICE_CDROM, - VIR_DOMAIN_DISK_BUS_SCSI, controller, unit, - &def->disks[def->ndisks], def) < 0) { + if (VIR_APPEND_ELEMENT(def->disks, def->ndisks, disk) < 0) goto cleanup; - } - - if (def->disks[def->ndisks] != NULL) - ++def->ndisks; } - } /* add all the SCSI controllers we've seen, up until the last one that is @@ -1787,27 +1783,27 @@ virVMXParseConfig(virVMXContext *ctx, continue; for (unit = 0; unit < 30; ++unit) { + g_autoptr(virDomainDiskDef) disk = NULL; + if (virVMXParseDisk(ctx, xmlopt, conf, VIR_DOMAIN_DISK_DEVICE_DISK, VIR_DOMAIN_DISK_BUS_SATA, controller, unit, - &def->disks[def->ndisks], def) < 0) { + &disk, def) < 0) { goto cleanup; } - if (def->disks[def->ndisks] != NULL) { - ++def->ndisks; - continue; - } - - if (virVMXParseDisk(ctx, xmlopt, conf, VIR_DOMAIN_DISK_DEVICE_CDROM, + if (!disk && + virVMXParseDisk(ctx, xmlopt, conf, VIR_DOMAIN_DISK_DEVICE_CDROM, VIR_DOMAIN_DISK_BUS_SATA, controller, unit, - &def->disks[def->ndisks], def) < 0) { + &disk, def) < 0) { goto cleanup; } - if (def->disks[def->ndisks] != NULL) - ++def->ndisks; + if (!disk) + continue; + + if (VIR_APPEND_ELEMENT(def->disks, def->ndisks, disk) < 0) + goto cleanup; } - } /* add all the SATA controllers we've seen, up until the last one that is @@ -1824,38 +1820,44 @@ virVMXParseConfig(virVMXContext *ctx, /* def:disks (ide) */ for (bus = 0; bus < 2; ++bus) { for (unit = 0; unit < 2; ++unit) { + g_autoptr(virDomainDiskDef) disk = NULL; + if (virVMXParseDisk(ctx, xmlopt, conf, VIR_DOMAIN_DISK_DEVICE_DISK, VIR_DOMAIN_DISK_BUS_IDE, bus, unit, - &def->disks[def->ndisks], def) < 0) { + &disk, def) < 0) { goto cleanup; } - if (def->disks[def->ndisks] != NULL) { - ++def->ndisks; + if (!disk && + virVMXParseDisk(ctx, xmlopt, conf, VIR_DOMAIN_DISK_DEVICE_CDROM, + VIR_DOMAIN_DISK_BUS_IDE, bus, unit, + &disk, def) < 0) { + goto cleanup; + } + + if (!disk) continue; - } - if (virVMXParseDisk(ctx, xmlopt, conf, VIR_DOMAIN_DISK_DEVICE_CDROM, - VIR_DOMAIN_DISK_BUS_IDE, bus, unit, - &def->disks[def->ndisks], def) < 0) { + if (VIR_APPEND_ELEMENT(def->disks, def->ndisks, disk) < 0) goto cleanup; - } - - if (def->disks[def->ndisks] != NULL) - ++def->ndisks; } } /* def:disks (floppy) */ for (unit = 0; unit < 2; ++unit) { + g_autoptr(virDomainDiskDef) disk = NULL; + if (virVMXParseDisk(ctx, xmlopt, conf, VIR_DOMAIN_DISK_DEVICE_FLOPPY, VIR_DOMAIN_DISK_BUS_FDC, 0, unit, - &def->disks[def->ndisks], def) < 0) { + &disk, def) < 0) { goto cleanup; } - if (def->disks[def->ndisks] != NULL) - ++def->ndisks; + if (!disk) + continue; + + if (VIR_APPEND_ELEMENT(def->disks, def->ndisks, disk) < 0) + goto cleanup; } /* def:fss */ -- 2.31.1

Libvirt assumes that a SCSI bus can fit up to 8 devices (including controller itself), except for so called wide bus which can accommodate up to 16 devices (again, including controller). This plays important role when computing 'drive' address in virDomainDiskDefAssignAddress(). So far, the only driver that enables wide SCSI bus is VMX. But with never releases, ESX is capable of "super wide" bus (64 devices). We can blindly bump the limit in our code because then we would compute address that's invalid for older ESX versions that we still want to support. Unfortunately, I haven't found a better place where to store this than virDomainDef. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; --- src/bhyve/bhyve_parse_command.c | 2 +- src/conf/domain_conf.c | 33 ++++++++++++++------------------- src/conf/domain_conf.h | 9 ++++++++- src/hyperv/hyperv_driver.c | 4 ++-- src/libxl/libxl_driver.c | 2 +- src/libxl/xen_xl.c | 2 +- src/libxl/xen_xm.c | 2 +- src/lxc/lxc_native.c | 2 +- src/openvz/openvz_conf.c | 2 +- src/qemu/qemu_process.c | 2 +- src/vbox/vbox_common.c | 8 ++++---- src/vmx/vmx.c | 2 +- src/vz/vz_sdk.c | 2 +- tests/genericxml2xmltest.c | 2 +- tests/openvzutilstest.c | 2 +- tests/qemublocktest.c | 2 +- tests/qemumonitortestutils.c | 2 +- tests/securityselinuxtest.c | 2 +- 18 files changed, 42 insertions(+), 40 deletions(-) diff --git a/src/bhyve/bhyve_parse_command.c b/src/bhyve/bhyve_parse_command.c index 9b97c262ec..7b3a830b45 100644 --- a/src/bhyve/bhyve_parse_command.c +++ b/src/bhyve/bhyve_parse_command.c @@ -956,7 +956,7 @@ bhyveParseCommandLineString(const char* nativeConfig, int loader_argc = 0; char **loader_argv = NULL; - if (!(def = virDomainDefNew())) + if (!(def = virDomainDefNew(xmlopt))) goto cleanup; /* Initialize defaults. */ diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 06c1fcf5e5..4ae78fa04d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -3790,7 +3790,7 @@ virDomainObjNew(virDomainXMLOption *xmlopt) virDomainDef * -virDomainDefNew(void) +virDomainDefNew(virDomainXMLOption *xmlopt) { virDomainDef *ret; @@ -3803,6 +3803,11 @@ virDomainDefNew(void) ret->mem.soft_limit = VIR_DOMAIN_MEMORY_PARAM_UNLIMITED; ret->mem.swap_hard_limit = VIR_DOMAIN_MEMORY_PARAM_UNLIMITED; + if (xmlopt && xmlopt->config.features & VIR_DOMAIN_DEF_FEATURE_WIDE_SCSI) + ret->scsiBusMaxUnit = SCSI_WIDE_BUS_MAX_CONT_UNIT; + else + ret->scsiBusMaxUnit = SCSI_NARROW_BUS_MAX_CONT_UNIT; + return ret; error: @@ -5130,12 +5135,11 @@ virDomainSCSIDriveAddressIsUsed(const virDomainDef *def, /* Find out the next usable "unit" of a specific controller */ static int virDomainControllerSCSINextUnit(const virDomainDef *def, - unsigned int max_unit, unsigned int controller) { size_t i; - for (i = 0; i < max_unit; i++) { + for (i = 0; i < def->scsiBusMaxUnit; i++) { /* Default to assigning addresses using bus = target = 0 */ const virDomainDeviceDriveAddress addr = {controller, 0, 0, i}; @@ -5147,22 +5151,13 @@ virDomainControllerSCSINextUnit(const virDomainDef *def, } -#define SCSI_WIDE_BUS_MAX_CONT_UNIT 16 -#define SCSI_NARROW_BUS_MAX_CONT_UNIT 7 - static void -virDomainHostdevAssignAddress(virDomainXMLOption *xmlopt, +virDomainHostdevAssignAddress(virDomainXMLOption *xmlopt G_GNUC_UNUSED, const virDomainDef *def, virDomainHostdevDef *hostdev) { int next_unit = 0; int controller = 0; - unsigned int max_unit; - - if (xmlopt->config.features & VIR_DOMAIN_DEF_FEATURE_WIDE_SCSI) - max_unit = SCSI_WIDE_BUS_MAX_CONT_UNIT; - else - max_unit = SCSI_NARROW_BUS_MAX_CONT_UNIT; /* NB: Do not attempt calling virDomainDefMaybeAddController to * automagically add a "new" controller. Doing so will result in @@ -5177,7 +5172,7 @@ virDomainHostdevAssignAddress(virDomainXMLOption *xmlopt, * hostdev being added to the as yet to be created controller. */ do { - next_unit = virDomainControllerSCSINextUnit(def, max_unit, controller); + next_unit = virDomainControllerSCSINextUnit(def, controller); if (next_unit < 0) controller++; } while (next_unit < 0); @@ -7647,7 +7642,7 @@ virDomainDeviceFindSCSIController(const virDomainDef *def, } int -virDomainDiskDefAssignAddress(virDomainXMLOption *xmlopt, +virDomainDiskDefAssignAddress(virDomainXMLOption *xmlopt G_GNUC_UNUSED, virDomainDiskDef *def, const virDomainDef *vmdef) { @@ -7667,14 +7662,14 @@ virDomainDiskDefAssignAddress(virDomainXMLOption *xmlopt, def->info.type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_DRIVE; - if (xmlopt->config.features & VIR_DOMAIN_DEF_FEATURE_WIDE_SCSI) { + if (vmdef->scsiBusMaxUnit > SCSI_NARROW_BUS_MAX_CONT_UNIT) { /* For a wide SCSI bus we define the default mapping to be * 16 units per bus, 1 bus per controller, many controllers. * Unit 7 is the SCSI controller itself. Therefore unit 7 * cannot be assigned to disks and is skipped. */ - controller = idx / 15; - unit = idx % 15; + controller = idx / (vmdef->scsiBusMaxUnit - 1); + unit = idx % (vmdef->scsiBusMaxUnit - 1); /* Skip the SCSI controller at unit 7 */ if (unit >= 7) @@ -19549,7 +19544,7 @@ virDomainDefParseXML(xmlDocPtr xml, return NULL; } - if (!(def = virDomainDefNew())) + if (!(def = virDomainDefNew(xmlopt))) return NULL; if (virDomainDefParseIDs(def, ctxt, flags, &uuid_generated) < 0) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index ca21082624..80dd1b96a4 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2726,6 +2726,11 @@ struct _virDomainVirtioOptions { virTristateSwitch packed; }; + +#define SCSI_WIDE_BUS_MAX_CONT_UNIT 16 +#define SCSI_NARROW_BUS_MAX_CONT_UNIT 7 + + /* * Guest VM main configuration * @@ -2904,6 +2909,8 @@ struct _virDomainDef { callbacks failed for a non-critical reason (was not able to fill in some data) and thus should be re-run before starting */ + + unsigned int scsiBusMaxUnit; }; @@ -3351,7 +3358,7 @@ virDomainGraphicsDefNew(virDomainXMLOption *xmlopt); virDomainNetDef * virDomainNetDefNew(virDomainXMLOption *xmlopt); -virDomainDef *virDomainDefNew(void); +virDomainDef *virDomainDefNew(virDomainXMLOption *xmlopt); void virDomainObjAssignDef(virDomainObj *domain, virDomainDef *def, diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index ff20d5548b..6e19cd6092 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@ -2688,7 +2688,7 @@ hypervDomainGetXMLDesc(virDomainPtr domain, unsigned int flags) virCheckFlags(VIR_DOMAIN_XML_COMMON_FLAGS, NULL); - if (!(def = virDomainDefNew())) + if (!(def = virDomainDefNew(priv->xmlopt))) return NULL; virUUIDFormat(domain->uuid, uuid_string); @@ -3058,7 +3058,7 @@ hypervDomainAttachDeviceFlags(virDomainPtr domain, const char *xml, unsigned int virUUIDFormat(domain->uuid, uuid_string); /* get domain definition */ - if (!(def = virDomainDefNew())) + if (!(def = virDomainDefNew(priv->xmlopt))) return -1; /* get domain device definition */ diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 0c3c53c1d1..6a3938ead4 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -584,7 +584,7 @@ libxlAddDom0(libxlDriverPrivate *driver) * created. */ if ((vm = virDomainObjListFindByID(driver->domains, 0)) == NULL) { - if (!(def = virDomainDefNew())) + if (!(def = virDomainDefNew(driver->xmlopt))) goto cleanup; def->id = 0; diff --git a/src/libxl/xen_xl.c b/src/libxl/xen_xl.c index c0905b08d8..066f39ffe3 100644 --- a/src/libxl/xen_xl.c +++ b/src/libxl/xen_xl.c @@ -1136,7 +1136,7 @@ xenParseXL(virConf *conf, { virDomainDef *def = NULL; - if (!(def = virDomainDefNew())) + if (!(def = virDomainDefNew(xmlopt))) return NULL; def->virtType = VIR_DOMAIN_VIRT_XEN; diff --git a/src/libxl/xen_xm.c b/src/libxl/xen_xm.c index feec25b9f4..1e0ea9e5b9 100644 --- a/src/libxl/xen_xm.c +++ b/src/libxl/xen_xm.c @@ -421,7 +421,7 @@ xenParseXM(virConf *conf, { virDomainDef *def = NULL; - if (!(def = virDomainDefNew())) + if (!(def = virDomainDefNew(xmlopt))) return NULL; def->virtType = VIR_DOMAIN_VIRT_XEN; diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c index 4bdd960e23..6ebd2e8e75 100644 --- a/src/lxc/lxc_native.c +++ b/src/lxc/lxc_native.c @@ -1109,7 +1109,7 @@ lxcParseConfigString(const char *config, if (!(properties = virConfReadString(config, VIR_CONF_FLAG_LXC_FORMAT))) return NULL; - if (!(vmdef = virDomainDefNew())) + if (!(vmdef = virDomainDefNew(xmlopt))) goto error; if (virUUIDGenerate(vmdef->uuid) < 0) { diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index 2a794801ae..a0ee4f8fb4 100644 --- a/src/openvz/openvz_conf.c +++ b/src/openvz/openvz_conf.c @@ -486,7 +486,7 @@ int openvzLoadDomains(struct openvz_driver *driver) } *line++ = '\0'; - if (!(def = virDomainDefNew())) + if (!(def = virDomainDefNew(driver->xmlopt))) goto cleanup; def->virtType = VIR_DOMAIN_VIRT_OPENVZ; diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 521fda57da..9dee6954bd 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -9117,7 +9117,7 @@ qemuProcessQMPConnectMonitor(qemuProcessQMP *proc) if (!(xmlopt = virDomainXMLOptionNew(NULL, NULL, NULL, NULL, NULL)) || !(proc->vm = virDomainObjNew(xmlopt)) || - !(proc->vm->def = virDomainDefNew())) + !(proc->vm->def = virDomainDefNew(xmlopt))) goto cleanup; proc->vm->pid = proc->pid; diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 1ca521321c..a6c9877944 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -4009,7 +4009,7 @@ static char *vboxDomainGetXMLDesc(virDomainPtr dom, unsigned int flags) if (openSessionForMachine(data, dom->uuid, &iid, &machine) < 0) goto cleanup; - if (!(def = virDomainDefNew())) + if (!(def = virDomainDefNew(data->xmlopt))) goto cleanup; gVBoxAPI.UIMachine.GetAccessible(machine, &accessible); @@ -4252,7 +4252,7 @@ static int vboxDomainAttachDeviceImpl(virDomainPtr dom, return ret; VBOX_IID_INITIALIZE(&iid); - if (!(def = virDomainDefNew())) + if (!(def = virDomainDefNew(data->xmlopt))) return ret; def->os.type = VIR_DOMAIN_OSTYPE_HVM; @@ -4371,7 +4371,7 @@ static int vboxDomainDetachDevice(virDomainPtr dom, const char *xml) return ret; VBOX_IID_INITIALIZE(&iid); - if (!(def = virDomainDefNew())) + if (!(def = virDomainDefNew(data->xmlopt))) return ret; def->os.type = VIR_DOMAIN_OSTYPE_HVM; @@ -6124,7 +6124,7 @@ static char *vboxDomainSnapshotGetXMLDesc(virDomainSnapshotPtr snapshot, goto cleanup; if (!(def = virDomainSnapshotDefNew()) || - !(def->parent.dom = virDomainDefNew())) + !(def->parent.dom = virDomainDefNew(data->xmlopt))) goto cleanup; defdom = def->parent.dom; def->parent.name = g_strdup(snapshot->name); diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 11b6fcbdf8..192f1bd252 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -1445,7 +1445,7 @@ virVMXParseConfig(virVMXContext *ctx, goto cleanup; /* Allocate domain def */ - if (!(def = virDomainDefNew())) + if (!(def = virDomainDefNew(xmlopt))) goto cleanup; def->virtType = VIR_DOMAIN_VIRT_VMWARE; diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index e09950812d..91102dca85 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -1809,7 +1809,7 @@ prlsdkLoadDomain(struct _vzDriver *driver, PRL_HANDLE job; char uuidstr[VIR_UUID_STRING_BRACED_BUFLEN]; - if (!(def = virDomainDefNew())) + if (!(def = virDomainDefNew(driver->xmlopt))) goto error; if (!(def->name = prlsdkGetStringParamVar(PrlVmCfg_GetName, sdkdom))) diff --git a/tests/genericxml2xmltest.c b/tests/genericxml2xmltest.c index ef51ed91a6..54622ea831 100644 --- a/tests/genericxml2xmltest.c +++ b/tests/genericxml2xmltest.c @@ -100,7 +100,7 @@ testCompareBackupXML(const void *opaque) } /* create a fake definition and fill it with disks */ - if (!(fakedef = virDomainDefNew())) + if (!(fakedef = virDomainDefNew(xmlopt))) return -1; fakedef->ndisks = backup->ndisks + 1; diff --git a/tests/openvzutilstest.c b/tests/openvzutilstest.c index 136c8011b8..ddb2fcbe6c 100644 --- a/tests/openvzutilstest.c +++ b/tests/openvzutilstest.c @@ -103,7 +103,7 @@ testReadNetworkConf(const void *data G_GNUC_UNUSED) .caps = openvzCapsInit(), }; - if (!(def = virDomainDefNew())) + if (!(def = virDomainDefNew(driver.xmlopt))) goto cleanup; def->os.init = g_strdup("/sbin/init"); diff --git a/tests/qemublocktest.c b/tests/qemublocktest.c index 0513e5bfc0..308668f2b8 100644 --- a/tests/qemublocktest.c +++ b/tests/qemublocktest.c @@ -279,7 +279,7 @@ testQemuDiskXMLToProps(const void *opaque) VIR_DOMAIN_DEF_PARSE_STATUS))) return -1; - if (!(vmdef = virDomainDefNew())) + if (!(vmdef = virDomainDefNew(data->driver->xmlopt))) return -1; virDomainDiskInsert(vmdef, disk); diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c index 143dd954e6..059d0d3b3b 100644 --- a/tests/qemumonitortestutils.c +++ b/tests/qemumonitortestutils.c @@ -1047,7 +1047,7 @@ qemuMonitorCommonTestNew(virDomainXMLOption *xmlopt, test->vm = virDomainObjNew(xmlopt); if (!test->vm) goto error; - if (!(test->vm->def = virDomainDefNew())) + if (!(test->vm->def = virDomainDefNew(xmlopt))) goto error; } diff --git a/tests/securityselinuxtest.c b/tests/securityselinuxtest.c index 9b65eeb994..119ad6df34 100644 --- a/tests/securityselinuxtest.c +++ b/tests/securityselinuxtest.c @@ -67,7 +67,7 @@ testBuildDomainDef(bool dynamic, virDomainDef *def; virSecurityLabelDef *secdef = NULL; - if (!(def = virDomainDefNew())) + if (!(def = virDomainDefNew(NULL))) goto error; def->virtType = VIR_DOMAIN_VIRT_KVM; -- 2.31.1

Since its 6.7 release, vSphere allows up to 64 units on a SCSI bus [1]. The release version translates to virtualHW_version 13 and thus if we are dealing with sufficiently new version we can enable the feature. 1: https://configmax.vmware.com/guest?vmwareproduct=vSphere&release=vSph... Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1738392 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; --- src/conf/domain_conf.h | 1 + src/vmx/vmx.c | 13 ++++++++----- tests/vmx2xmldata/vmx2xml-esx-in-the-wild-11.xml | 5 +++++ 3 files changed, 14 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 80dd1b96a4..c57b77a59c 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2727,6 +2727,7 @@ struct _virDomainVirtioOptions { }; +#define SCSI_SUPER_WIDE_BUS_MAX_CONT_UNIT 64 #define SCSI_WIDE_BUS_MAX_CONT_UNIT 16 #define SCSI_NARROW_BUS_MAX_CONT_UNIT 7 diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 192f1bd252..f706e2023a 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -1476,6 +1476,8 @@ virVMXParseConfig(virVMXContext *ctx, "4 or higher but found %lld"), virtualHW_version); goto cleanup; + } else if (virtualHW_version >= 13) { + def->scsiBusMaxUnit = SCSI_SUPER_WIDE_BUS_MAX_CONT_UNIT; } /* vmx:uuid.bios -> def:uuid */ @@ -1729,7 +1731,7 @@ virVMXParseConfig(virVMXContext *ctx, if (! present) continue; - for (unit = 0; unit < 16; ++unit) { + for (unit = 0; unit < def->scsiBusMaxUnit; unit++) { g_autoptr(virDomainDiskDef) disk = NULL; if (unit == 7) { @@ -2169,7 +2171,8 @@ virVMXParseDisk(virVMXContext *ctx, virDomainXMLOption *xmlopt, virConf *conf, * VIR_DOMAIN_DISK_DEVICE_LUN} * busType = VIR_DOMAIN_DISK_BUS_SCSI * controllerOrBus = [0..3] -> controller - * unit = [0..6,8..15] + * unit = [0..6,8..15] for virtualHW_version < 13 + * unit = [0..6,8..64] for virtualHW_version >= 13 * * device = {VIR_DOMAIN_DISK_DEVICE_DISK, * VIR_DOMAIN_DISK_DEVICE_CDROM, @@ -2235,10 +2238,10 @@ virVMXParseDisk(virVMXContext *ctx, virDomainXMLOption *xmlopt, virConf *conf, goto cleanup; } - if (unit < 0 || unit > 15 || unit == 7) { + if (unit < 0 || unit > vmdef->scsiBusMaxUnit || unit == 7) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("SCSI unit index %d out of [0..6,8..15] range"), - unit); + _("SCSI unit index %d out of [0..6,8..%u] range"), + unit, vmdef->scsiBusMaxUnit); goto cleanup; } diff --git a/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-11.xml b/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-11.xml index cf414975b3..8807a057d7 100644 --- a/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-11.xml +++ b/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-11.xml @@ -20,6 +20,11 @@ <target dev='sda' bus='scsi'/> <address type='drive' controller='0' bus='0' target='0' unit='0'/> </disk> + <disk type='file' device='disk'> + <source file='[datastore] directory/esx6.7-rhel7.7-x86_64_3.vmdk'/> + <target dev='sdp' bus='scsi'/> + <address type='drive' controller='0' bus='0' target='0' unit='16'/> + </disk> <controller type='scsi' index='0' model='vmpvscsi'/> <interface type='bridge'> <mac address='00:50:56:ac:3e:a1' type='generated'/> -- 2.31.1