On Fri, Nov 12, 2010 at 02:03:34PM +0100, Matthias Bolte wrote: > This makes the storage driver fail when the connection is > opened with the VIR_CONNECT_RO flag, resulting in a read-only > connection with no storage driver. > --- >  src/phyp/phyp_driver.c |    4 +--- >  1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c > index a685bd1..4c723a2 100644 > --- a/src/phyp/phyp_driver.c > +++ b/src/phyp/phyp_driver.c > @@ -3927,10 +3927,8 @@ phypDomainSetCPU(virDomainPtr dom, unsigned int nvcpus) >  static virDrvOpenStatus >  phypVIOSDriverOpen(virConnectPtr conn, >                     virConnectAuthPtr auth ATTRIBUTE_UNUSED, > -                   int flags) > +                   int flags ATTRIBUTE_UNUSED) >  { > -    virCheckFlags(0, VIR_DRV_OPEN_ERROR); > - >      if (conn->driver->no != VIR_DRV_PHYP) >          return VIR_DRV_OPEN_DECLINED; > ACK Daniel

On 11/12/2010 06:03 AM, Matthias Bolte wrote: > This makes the storage driver fail when the connection is > opened with the VIR_CONNECT_RO flag, resulting in a read-only > connection with no storage driver. > --- > src/phyp/phyp_driver.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c > index a685bd1..4c723a2 100644 > --- a/src/phyp/phyp_driver.c > +++ b/src/phyp/phyp_driver.c > @@ -3927,10 +3927,8 @@ phypDomainSetCPU(virDomainPtr dom, unsigned int nvcpus) > static virDrvOpenStatus > phypVIOSDriverOpen(virConnectPtr conn, > virConnectAuthPtr auth ATTRIBUTE_UNUSED, > - int flags) > + int flags ATTRIBUTE_UNUSED) > { > - virCheckFlags(0, VIR_DRV_OPEN_ERROR); > - This lets all possible flags through, even bits that are not yet defined. Wouldn't the better approach be to fix virCheckFlags() to change 0 to the actual read-only bit that we expect to ignore, while still forbidding the remaining 31 bits for future extensibility?