12:31 a.m.
This patch series is to add PCI passthrough support to libxenlight driver so that
it can create VM with managed/non-managed host pci device defined.
Chunyan Liu (2):
libxl: add APIs to prepare/release host pci device
libxl: support pci passthrough
po/POTFILES.in | 1 +
src/Makefile.am | 1 +
src/libxl/libxl_conf.c | 44 ++++
src/libxl/libxl_conf.h | 5 +-
src/libxl/libxl_driver.c | 16 ++
src/libxl/libxl_hostdev.c | 600 +++++++++++++++++++++++++++++++++++++++++++++
src/libxl/libxl_hostdev.h | 44 ++++
7 files changed, 710 insertions(+), 1 deletions(-)
create mode 100644 src/libxl/libxl_hostdev.c
create mode 100644 src/libxl/libxl_hostdev.h
--
1.7.3.4
2:42 a.m.
On 01/11/13 07:31, Chunyan Liu wrote:
This patch series is to add PCI passthrough support to libxenlight
driver so that
it can create VM with managed/non-managed host pci device defined.
Chunyan Liu (2):
libxl: add APIs to prepare/release host pci device
libxl: support pci passthrough
po/POTFILES.in | 1 +
src/Makefile.am | 1 +
src/libxl/libxl_conf.c | 44 ++++
src/libxl/libxl_conf.h | 5 +-
src/libxl/libxl_driver.c | 16 ++
src/libxl/libxl_hostdev.c | 600 +++++++++++++++++++++++++++++++++++++++++++++
src/libxl/libxl_hostdev.h | 44 ++++
7 files changed, 710 insertions(+), 1 deletions(-)
create mode 100644 src/libxl/libxl_hostdev.c
create mode 100644 src/libxl/libxl_hostdev.h
Please don't answer "y" when git send email shows the following prompt:
"Message-ID to be used as In-Reply-To for the first email?"
you should respond with a message ID there. Unfortunately we have a
growing thread that contains submissions with this mistake.
Please resend your series as a proper new thread.
Thanks.
Peter
10:39 a.m.
New subject: [libvirt] git send-email should not allow 'y' for in-reply-to
[raising this UI wart to the git list]
On 01/11/2013 01:42 AM, Peter Krempa wrote:
On 01/11/13 07:31, Chunyan Liu wrote:
> This patch series is to...
[snip]
Please don't answer "y" when git send email shows the following prompt:
"Message-ID to be used as In-Reply-To for the first email?"
you should respond with a message ID there. Unfortunately we have a
growing thread that contains submissions with this mistake.
Anyone willing to patch upstream 'git send-email' to reject a simple 'y'
rather than blindly sending a bad messageID for the in-reply-to field,
to help future users avoid this mistake? Obviously, it won't help until
the patch eventually percolates into distros, so it would be a few more
months before we see the benefits, but down the road it will prevent
confusing threads.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
10:47 a.m.
New subject: [libvirt] git send-email should not allow 'y' for in-reply-to
On Fri, Jan 11, 2013 at 09:39:06AM -0700, Eric Blake wrote:
> Please don't answer "y" when git send email shows
the following prompt:
>
> "Message-ID to be used as In-Reply-To for the first email?"
>
> you should respond with a message ID there. Unfortunately we have a
> growing thread that contains submissions with this mistake.
Anyone willing to patch upstream 'git send-email' to reject a simple 'y'
rather than blindly sending a bad messageID for the in-reply-to field,
to help future users avoid this mistake? Obviously, it won't help until
the patch eventually percolates into distros, so it would be a few more
months before we see the benefits, but down the road it will prevent
confusing threads.
What version of git? Commit 51bbccf is in v1.7.12.1 and higher, and
says:
$ git show 51bbccf
commit 51bbccfd1b4a9e2807413022c56ab05c835164fb
Author: Junio C Hamano <gitster(a)pobox.com>
Date: Tue Aug 14 15:15:53 2012 -0700
send-email: validate & reconfirm interactive responses
People answer 'y' to "Who should the emails appear to be from?" and
'n' to "Message-ID to be used as In-Reply-To for the first email?"
for some unknown reason. While it is possible that your local
username really is "y" and you are sending the mail to your local
colleagues, it is possible, and some might even say it is likely,
that it is a user error.
Fortunately, our interactive prompter already has input validation
mechanism built-in. Enhance it so that we can optionally reconfirm
and allow the user to pass an input that does not validate, and
"softly" require input to the sender, in-reply-to, and recipient to
contain "@" and "." in this order, which would catch most cases of
mistakes.
-Peff
11:51 a.m.
New subject: [libvirt] git send-email should not allow 'y' for in-reply-to
On 01/11/2013 09:47 AM, Jeff King wrote:
On Fri, Jan 11, 2013 at 09:39:06AM -0700, Eric Blake wrote:
>> Please don't answer "y" when git send email shows the following
prompt:
>>
>
> Anyone willing to patch upstream 'git send-email' to reject a simple
'y'
What version of git? Commit 51bbccf is in v1.7.12.1 and higher, and
says:
$ git show 51bbccf
commit 51bbccfd1b4a9e2807413022c56ab05c835164fb
Author: Junio C Hamano <gitster(a)pobox.com>
Date: Tue Aug 14 15:15:53 2012 -0700
send-email: validate & reconfirm interactive responses
People answer 'y' to "Who should the emails appear to be from?" and
'n' to "Message-ID to be used as In-Reply-To for the first email?"
for some unknown reason. While it is possible that your local
username really is "y" and you are sending the mail to your local
colleagues, it is possible, and some might even say it is likely,
that it is a user error.
Awesome! Already implemented! In the case that sparked this particular
email, the culprit was using 1.7.3.4; earlier this month, a separate
culprit to the same libvirt mailing list was using 1.7.11.7.
I was right about it needing to take a few months to percolate to the
actual users.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
12:43 p.m.
New subject: [libvirt] git send-email should not allow 'y' for in-reply-to
On 11 January 2013 08:47, Jeff King <peff(a)peff.net> wrote:
On Fri, Jan 11, 2013 at 09:39:06AM -0700, Eric Blake wrote:
> > Please don't answer "y" when git send email shows the following
prompt:
> >
> > "Message-ID to be used as In-Reply-To for the first email?"
> >
> > you should respond with a message ID there. Unfortunately we have a
> > growing thread that contains submissions with this mistake.
<snip/>
People answer 'y' to "Who should the emails appear to
be from?" and
'n' to "Message-ID to be used as In-Reply-To for the first email?"
for some unknown reason. While it is possible that your local
username really is "y" and you are sending the mail to your local
colleagues, it is possible, and some might even say it is likely,
that it is a user error.
I have never used Git's email support so this doesn't affect me one
way or another but it seems that checking the results is fixing the
symptoms, not the problem? I apologize if this was already discussed
but I couldn't find such a discussion.
I was wondering if it might be a better idea to change the wording of
the questions if they have proven so confusing? The first time (just
now) that I read "Message-ID to be used as In-Reply-To for the first
email?", it clearly seemed like a yes/no question to me. :-)
How about "What Message-ID to use as In-Reply-To for the first email?"
or "Provide the Message-ID to use as In-Reply-To for the first
email:". I'm a little surprised that "Who should the emails appear to
be from?" would be interpreted as a yes/no question but we could
rephrase that similarly as "Provide the name of the email sender:" (I
don't really like this particular version but you get the idea).
12:54 p.m.
New subject: [libvirt] git send-email should not allow 'y' for in-reply-to
On Fri, Jan 11, 2013 at 10:43:39AM -0800, Hilco Wijbenga wrote:
> People answer 'y' to "Who should the emails
appear to be from?" and
> 'n' to "Message-ID to be used as In-Reply-To for the first
email?"
> for some unknown reason. While it is possible that your local
> username really is "y" and you are sending the mail to your local
> colleagues, it is possible, and some might even say it is likely,
> that it is a user error.
I have never used Git's email support so this doesn't affect me one
way or another but it seems that checking the results is fixing the
symptoms, not the problem? I apologize if this was already discussed
but I couldn't find such a discussion.
It depends on who you are. If you are the person running send-email,
then the symptom is your confusion. If you are somebody else, the
symptom is somebody else sending out a bogus email. That patch fixes
only the latter. :)
More seriously, I agree that re-wording the question is a reasonable
thing to do. I do not use send-email, either, so I don't have a strong
opinion on it. The suggestions you made:
How about "What Message-ID to use as In-Reply-To for the first
email?"
or "Provide the Message-ID to use as In-Reply-To for the first
email:".
seem fine to me. Maybe somebody who has been confused by it can offer
more. At any rate, patches welcome.
-Peff
3:03 a.m.
New subject: [libvirt] git send-email should not allow 'y' for in-reply-to
Jeff King <peff(a)peff.net> writes:
On Fri, Jan 11, 2013 at 10:43:39AM -0800, Hilco Wijbenga wrote:
...
More seriously, I agree that re-wording the question is a reasonable
thing to do. I do not use send-email, either, so I don't have a strong
opinion on it. The suggestions you made:
> How about "What Message-ID to use as In-Reply-To for the first email?"
> or "Provide the Message-ID to use as In-Reply-To for the first
> email:".
seem fine to me. Maybe somebody who has been confused by it can offer
more. At any rate, patches welcome.
Has anything come out of this discussion? Is the current phrasing
fine as-is?
4289
days inactive
4333
days old
7 comments
6 participants
participants (6)
-
Chunyan Liu -
Eric Blake -
Hilco Wijbenga -
Jeff King -
Junio C Hamano -
Peter Krempa