[libvirt] [PATCH 0/2] udev: Remove udev handle from main loop when udev thread stops
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
Changelog:
+ RFC -> v1:
- Remove the event handle in the error path of nodeStateInitializeEnumerate
- Added patch 2: wake up udev thread in case of an error
Marc Hartmayer (2):
udev: nodeStateInitializeEnumerate: remove watch handle in case of an
error
udev: wake up the udev thread for stopping it
src/node_device/node_device_udev.c | 3 +++
1 file changed, 3 insertions(+)
--
2.17.0
Wednesday, 20 February
Wed, 20 Feb
4:05 a.m.
New subject: [libvirt] [PATCH 1/2] udev: nodeStateInitializeEnumerate: remove watch handle in case of an error
If the udev thread is stopped, it must be ensured that the watch
handle is also removed from the main loop.
Signed-off-by: Marc Hartmayer <mhartmay(a)linux.ibm.com>
---
src/node_device/node_device_udev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
index 54f372cd4a9f..4dd2e9004fd7 100644
--- a/src/node_device/node_device_udev.c
+++ b/src/node_device/node_device_udev.c
@@ -1802,6 +1802,8 @@ nodeStateInitializeEnumerate(void *opaque)
error:
virObjectLock(priv);
+ ignore_value(virEventRemoveHandle(priv->watch));
+ priv->watch = -1;
priv->threadQuit = true;
virObjectUnlock(priv);
}
--
2.17.0
4:05 a.m.
New subject: [libvirt] [PATCH 2/2] udev: wake up the udev thread for stopping it
Signal the udev thread the change of `priv->threadQuit` by using the
thread condition.
Signed-off-by: Marc Hartmayer <mhartmay(a)linux.ibm.com>
---
src/node_device/node_device_udev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
index 4dd2e9004fd7..32e762009f1c 100644
--- a/src/node_device/node_device_udev.c
+++ b/src/node_device/node_device_udev.c
@@ -1805,6 +1805,7 @@ nodeStateInitializeEnumerate(void *opaque)
ignore_value(virEventRemoveHandle(priv->watch));
priv->watch = -1;
priv->threadQuit = true;
+ virCondSignal(&priv->threadCond);
virObjectUnlock(priv);
}
--
2.17.0
On 2/20/19 5:05 AM, Marc Hartmayer wrote:
Changelog:
+ RFC -> v1:
- Remove the event handle in the error path of nodeStateInitializeEnumerate
- Added patch 2: wake up udev thread in case of an error
Marc Hartmayer (2):
udev: nodeStateInitializeEnumerate: remove watch handle in case of an
error
udev: wake up the udev thread for stopping it
src/node_device/node_device_udev.c | 3 +++
1 file changed, 3 insertions(+)
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
(series) and pushed,
Tks -
John
2067
days inactive
2067
days old
3 comments
2 participants
tags (0)
participants (2)
-
John Ferlan -
Marc Hartmayer