[libvirt] persistence of pcihole64 over live migration
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
Hello all,
In order to reserve 64-bit address space for hotplugging, we are using the pcihole64
attribute on the root pci-controller.
When doing a live-migration using libvirt/qemu, the pci-root controller is dropped and
re-added on the destination side[1], which results in the pci controller's pcihole64
attribute that we configured when launching the VM being lost.
Is there any reason to not keep this (by not dropping it in qemuDomainDefFormatBufInternal
when pcihole64 is set on the controller) over a live migration in this case?
[1] https://github.com/libvirt/libvirt/commit/b33eb0dca1175bc0e3f796f18e31adc...
Thanks,
Joseph Richard
Attachments:
- attachment.html (text/html — 3.1 KB)
On Tue, Mar 20, 2018 at 20:34:37 +0000, Richard, Joseph wrote:
Hello all,
In order to reserve 64-bit address space for hotplugging, we are using the pcihole64
attribute on the root pci-controller.
When doing a live-migration using libvirt/qemu, the pci-root controller is dropped and
re-added on the destination side[1], which results in the pci controller's pcihole64
attribute that we configured when launching the VM being lost.
Is there any reason to not keep this (by not dropping it in
qemuDomainDefFormatBufInternal when pcihole64 is set on the controller) over a live
migration in this case?
I think that's probably an oversight. The pcihole64 was introduced
later and nobody realized the controller is dropped during migration.
The controller is dropped for backward compatibility with older libvirt
which didn't represent it in the XML. But once its configuration is
different from the one libvirt would add by itself, we definitely don't
want to drop it. Successful migration with such configuration would need
a new libvirt which understands the changed configuration anyway so it
wouldn't complain about unknown device when parsing the XML.
Jirka
On Tue, Mar 20, 2018 at 08:34:37PM +0000, Richard, Joseph wrote:
Hello all,
In order to reserve 64-bit address space for hotplugging, we are using the pcihole64
attribute on the root pci-controller.
When doing a live-migration using libvirt/qemu, the pci-root controller is dropped and
re-added on the destination side[1], which results in the pci controller's pcihole64
attribute that we configured when launching the VM being lost.
Is there any reason to not keep this (by not dropping it in qemuDomainDefFormatBufInternal
when pcihole64 is set on the controller) over a live migration in this case?
[1] https://github.com/libvirt/libvirt/commit/b33eb0dca1175bc0e3f796f18e31adc...
Thanks for the report.
Proposed fix:
https://www.redhat.com/archives/libvir-list/2018-March/msg01536.html
Subject: [PATCH 0/2] Fix migration with implicit controllers (user-alias saga)
Message-Id: <cover.1522005826.git.jtomko(a)redhat.com>
Jano
2470
days inactive
2475
days old
2 comments
3 participants
tags (0)
participants (3)
-
Jiri Denemark -
Ján Tomko -
Richard, Joseph