5:47 a.m.
Patch 1 is related to the on list iotune length/duration parameter
Patch 2 is related to the already pushed vcpu hotpluggable flag
These would be pushed once I push the blkdeviotune changes - the order
was only because I made the blkdeviotune changes, then built and found
that the vcpu hotpluggable flag cause test failure.
John Ferlan (2):
Add blkdeviotune length parameters
Add VIR_DOMAIN_VCPU_HOTPLUGGABLE
Changes | 3 ++-
Virt.xs | 13 +++++++++++++
lib/Sys/Virt/Domain.pm | 29 +++++++++++++++++++++++++++++
3 files changed, 44 insertions(+), 1 deletion(-)
--
2.7.4
5:47 a.m.
New subject: [libvirt] [libvirt-perl PATCH 1/2] Add blkdeviotune length parameters
Add VIR_DOMAIN_BLOCK_IOTUNE*LENGTH and VIR_DOMAIN_TUNABLE_BLKDEV*LENGTH
parameters and their descriptions.
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
Changes | 2 +-
Virt.xs | 12 ++++++++++++
lib/Sys/Virt/Domain.pm | 25 +++++++++++++++++++++++++
3 files changed, 38 insertions(+), 1 deletion(-)
diff --git a/Changes b/Changes
index 4985100..8d5683a 100644
--- a/Changes
+++ b/Changes
@@ -2,7 +2,7 @@ Revision history for perl module Sys::Virt
2.4.0 2016-00-00
- - XXX
+ - Add constants for the new block iotune parameters for length
2.3.0 2016-10-06
diff --git a/Virt.xs b/Virt.xs
index b4ca049..88ed722 100644
--- a/Virt.xs
+++ b/Virt.xs
@@ -8275,6 +8275,12 @@ BOOT:
REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_READ_IOPS_SEC_MAX,
BLOCK_IOTUNE_READ_IOPS_SEC_MAX);
REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX,
BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX);
REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_SIZE_IOPS_SEC,
BLOCK_IOTUNE_SIZE_IOPS_SEC);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_BYTES_SEC_MAX_LENGTH,
BLOCK_IOTUNE_TOTAL_BYTES_SEC_MAX_LENGTH);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_READ_BYTES_SEC_MAX_LENGTH,
BLOCK_IOTUNE_READ_BYTES_SEC_MAX_LENGTH);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_WRITE_BYTES_SEC_MAX_LENGTH,
BLOCK_IOTUNE_WRITE_BYTES_SEC_MAX_LENGTH);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_IOPS_SEC_MAX_LENGTH,
BLOCK_IOTUNE_TOTAL_IOPS_SEC_MAX_LENGTH);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_READ_IOPS_SEC_MAX_LENGTH,
BLOCK_IOTUNE_READ_IOPS_SEC_MAX_LENGTH);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX_LENGTH,
BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX_LENGTH);
REGISTER_CONSTANT(VIR_DOMAIN_BLOCK_RESIZE_BYTES, BLOCK_RESIZE_BYTES);
@@ -8484,6 +8490,12 @@ BOOT:
REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_BYTES_SEC_MAX,
TUNABLE_BLKDEV_TOTAL_BYTES_SEC_MAX);
REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_IOPS_SEC_MAX,
TUNABLE_BLKDEV_TOTAL_IOPS_SEC_MAX);
REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_SIZE_IOPS_SEC,
TUNABLE_BLKDEV_SIZE_IOPS_SEC);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_READ_BYTES_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_READ_BYTES_SEC_MAX_LENGTH);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_READ_IOPS_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_READ_IOPS_SEC_MAX_LENGTH);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_WRITE_BYTES_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_WRITE_BYTES_SEC_MAX_LENGTH);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_WRITE_IOPS_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_WRITE_IOPS_SEC_MAX_LENGTH);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_BYTES_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_TOTAL_BYTES_SEC_MAX_LENGTH);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_IOPS_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_TOTAL_IOPS_SEC_MAX_LENGTH);
REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_CPU_IOTHREADSPIN, TUNABLE_IOTHREADSPIN);
diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm
index e37b078..8bf4115 100644
--- a/lib/Sys/Virt/Domain.pm
+++ b/lib/Sys/Virt/Domain.pm
@@ -2566,6 +2566,31 @@ The maximum I/O operations written per second.
The maximum I/O operations per second
+=item Sys::Virt::Domain::BLOCK_IOTUNE_TOTAL_BYTES_SEC_MAX_LENGTH
+
+The duration in seconds allowed for maximum total bytes processed per second.
+
+=item Sys::Virt::Domain::BLOCK_IOTUNE_READ_BYTES_SEC_MAX_LENGTH
+
+The duration in seconds allowed for maximum bytes read per second.
+
+=item Sys::Virt::Domain::BLOCK_IOTUNE_WRITE_BYTES_SEC_MAX_LENGTH
+
+The duration in seconds allowed for maximum bytes written per second.
+
+=item Sys::Virt::Domain::BLOCK_IOTUNE_TOTAL_IOPS_SEC_MAX_LENGTH
+
+The duration in seconds allowed for maximum total I/O operations processed
+per second.
+
+=item Sys::Virt::Domain::BLOCK_IOTUNE_READ_IOPS_SEC_MAX_LENGTH
+
+The duration in seconds allowed for maximum I/O operations read per second.
+
+=item Sys::Virt::Domain::BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX_LENGTH
+
+The duration in seconds allowed for maximum I/O operations written per second.
+
=back
=head2 SCHEDULER CONSTANTS
--
2.7.4
5:58 a.m.
New subject: [libvirt] [libvirt-perl PATCH 1/2] Add blkdeviotune length parameters
On Fri, Oct 07, 2016 at 06:47:04AM -0400, John Ferlan wrote:
Add VIR_DOMAIN_BLOCK_IOTUNE*LENGTH and
VIR_DOMAIN_TUNABLE_BLKDEV*LENGTH
parameters and their descriptions.
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
Changes | 2 +-
Virt.xs | 12 ++++++++++++
lib/Sys/Virt/Domain.pm | 25 +++++++++++++++++++++++++
3 files changed, 38 insertions(+), 1 deletion(-)
diff --git a/Changes b/Changes
index 4985100..8d5683a 100644
--- a/Changes
+++ b/Changes
@@ -2,7 +2,7 @@ Revision history for perl module Sys::Virt
2.4.0 2016-00-00
- - XXX
+ - Add constants for the new block iotune parameters for length
2.3.0 2016-10-06
diff --git a/Virt.xs b/Virt.xs
index b4ca049..88ed722 100644
--- a/Virt.xs
+++ b/Virt.xs
@@ -8275,6 +8275,12 @@ BOOT:
REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_READ_IOPS_SEC_MAX,
BLOCK_IOTUNE_READ_IOPS_SEC_MAX);
REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX,
BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX);
REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_SIZE_IOPS_SEC,
BLOCK_IOTUNE_SIZE_IOPS_SEC);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_BYTES_SEC_MAX_LENGTH,
BLOCK_IOTUNE_TOTAL_BYTES_SEC_MAX_LENGTH);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_READ_BYTES_SEC_MAX_LENGTH,
BLOCK_IOTUNE_READ_BYTES_SEC_MAX_LENGTH);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_WRITE_BYTES_SEC_MAX_LENGTH,
BLOCK_IOTUNE_WRITE_BYTES_SEC_MAX_LENGTH);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_IOPS_SEC_MAX_LENGTH,
BLOCK_IOTUNE_TOTAL_IOPS_SEC_MAX_LENGTH);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_READ_IOPS_SEC_MAX_LENGTH,
BLOCK_IOTUNE_READ_IOPS_SEC_MAX_LENGTH);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX_LENGTH,
BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX_LENGTH);
REGISTER_CONSTANT(VIR_DOMAIN_BLOCK_RESIZE_BYTES, BLOCK_RESIZE_BYTES);
@@ -8484,6 +8490,12 @@ BOOT:
REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_BYTES_SEC_MAX,
TUNABLE_BLKDEV_TOTAL_BYTES_SEC_MAX);
REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_IOPS_SEC_MAX,
TUNABLE_BLKDEV_TOTAL_IOPS_SEC_MAX);
REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_SIZE_IOPS_SEC,
TUNABLE_BLKDEV_SIZE_IOPS_SEC);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_READ_BYTES_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_READ_BYTES_SEC_MAX_LENGTH);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_READ_IOPS_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_READ_IOPS_SEC_MAX_LENGTH);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_WRITE_BYTES_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_WRITE_BYTES_SEC_MAX_LENGTH);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_WRITE_IOPS_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_WRITE_IOPS_SEC_MAX_LENGTH);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_BYTES_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_TOTAL_BYTES_SEC_MAX_LENGTH);
+ REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_IOPS_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_TOTAL_IOPS_SEC_MAX_LENGTH);
REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_CPU_IOTHREADSPIN, TUNABLE_IOTHREADSPIN);
You missed docs these this set of constants, so i'm suprised
make test didn't complain
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
6:18 a.m.
New subject: [libvirt] [libvirt-perl PATCH 1/2] Add blkdeviotune length parameters
On 10/07/2016 06:58 AM, Daniel P. Berrange wrote:
On Fri, Oct 07, 2016 at 06:47:04AM -0400, John Ferlan wrote:
> Add VIR_DOMAIN_BLOCK_IOTUNE*LENGTH and VIR_DOMAIN_TUNABLE_BLKDEV*LENGTH
> parameters and their descriptions.
>
> Signed-off-by: John Ferlan <jferlan(a)redhat.com>
> ---
> Changes | 2 +-
> Virt.xs | 12 ++++++++++++
> lib/Sys/Virt/Domain.pm | 25 +++++++++++++++++++++++++
> 3 files changed, 38 insertions(+), 1 deletion(-)
>
> diff --git a/Changes b/Changes
> index 4985100..8d5683a 100644
> --- a/Changes
> +++ b/Changes
> @@ -2,7 +2,7 @@ Revision history for perl module Sys::Virt
>
> 2.4.0 2016-00-00
>
> - - XXX
> + - Add constants for the new block iotune parameters for length
>
> 2.3.0 2016-10-06
>
> diff --git a/Virt.xs b/Virt.xs
> index b4ca049..88ed722 100644
> --- a/Virt.xs
> +++ b/Virt.xs
> @@ -8275,6 +8275,12 @@ BOOT:
> REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_READ_IOPS_SEC_MAX,
BLOCK_IOTUNE_READ_IOPS_SEC_MAX);
> REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX,
BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX);
> REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_SIZE_IOPS_SEC,
BLOCK_IOTUNE_SIZE_IOPS_SEC);
> + REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_BYTES_SEC_MAX_LENGTH,
BLOCK_IOTUNE_TOTAL_BYTES_SEC_MAX_LENGTH);
> + REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_READ_BYTES_SEC_MAX_LENGTH,
BLOCK_IOTUNE_READ_BYTES_SEC_MAX_LENGTH);
> + REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_WRITE_BYTES_SEC_MAX_LENGTH,
BLOCK_IOTUNE_WRITE_BYTES_SEC_MAX_LENGTH);
> + REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_IOPS_SEC_MAX_LENGTH,
BLOCK_IOTUNE_TOTAL_IOPS_SEC_MAX_LENGTH);
> + REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_READ_IOPS_SEC_MAX_LENGTH,
BLOCK_IOTUNE_READ_IOPS_SEC_MAX_LENGTH);
> + REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX_LENGTH,
BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX_LENGTH);
>
>
> REGISTER_CONSTANT(VIR_DOMAIN_BLOCK_RESIZE_BYTES, BLOCK_RESIZE_BYTES);
> @@ -8484,6 +8490,12 @@ BOOT:
> REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_BYTES_SEC_MAX,
TUNABLE_BLKDEV_TOTAL_BYTES_SEC_MAX);
> REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_IOPS_SEC_MAX,
TUNABLE_BLKDEV_TOTAL_IOPS_SEC_MAX);
> REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_SIZE_IOPS_SEC,
TUNABLE_BLKDEV_SIZE_IOPS_SEC);
> + REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_READ_BYTES_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_READ_BYTES_SEC_MAX_LENGTH);
> + REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_READ_IOPS_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_READ_IOPS_SEC_MAX_LENGTH);
> + REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_WRITE_BYTES_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_WRITE_BYTES_SEC_MAX_LENGTH);
> + REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_WRITE_IOPS_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_WRITE_IOPS_SEC_MAX_LENGTH);
> + REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_BYTES_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_TOTAL_BYTES_SEC_MAX_LENGTH);
> + REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_IOPS_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_TOTAL_IOPS_SEC_MAX_LENGTH);
> REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_CPU_IOTHREADSPIN,
TUNABLE_IOTHREADSPIN);
You missed docs these this set of constants, so i'm suprised
make test didn't complain
Oh right - forgot the second hunk... They're just a copy of the BLOCK
tunable anyway, so I copied and renamed the params to match the other
TUNABLE_BLKDEV defs in lib/Sys/Virt/Domain.pm:
diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm
index 8bf4115..b2488a6 100644
--- a/lib/Sys/Virt/Domain.pm
+++ b/lib/Sys/Virt/Domain.pm
@@ -4297,6 +4297,31 @@ Maximum write throughput in I/O operations per sec
The maximum I/O operations per second
+=item Sys::Virt::Domain::TUNABLE_BLKDEV_TOTAL_BYTES_SEC_MAX_LENGTH
+
+The duration in seconds allowed for maximum total bytes processed per
second.
+
+=item Sys::Virt::Domain::TUNABLE_BLKDEV_READ_BYTES_SEC_MAX_LENGTH
+
+The duration in seconds allowed for maximum bytes read per second.
+
+=item Sys::Virt::Domain::TUNABLE_BLKDEV_WRITE_BYTES_SEC_MAX_LENGTH
+
+The duration in seconds allowed for maximum bytes written per second.
+
+=item Sys::Virt::Domain::TUNABLE_BLKDEV_TOTAL_IOPS_SEC_MAX_LENGTH
+
+The duration in seconds allowed for maximum total I/O operations processed
+per second.
+
+=item Sys::Virt::Domain::TUNABLE_BLKDEV_READ_IOPS_SEC_MAX_LENGTH
+
+The duration in seconds allowed for maximum I/O operations read per second.
+
+=item Sys::Virt::Domain::TUNABLE_BLKDEV_WRITE_IOPS_SEC_MAX_LENGTH
+
+The duration in seconds allowed for maximum I/O operations written per
second.
+
John
6:25 a.m.
New subject: [libvirt] [libvirt-perl PATCH 1/2] Add blkdeviotune length parameters
On Fri, Oct 07, 2016 at 07:18:01AM -0400, John Ferlan wrote:
On 10/07/2016 06:58 AM, Daniel P. Berrange wrote:
> On Fri, Oct 07, 2016 at 06:47:04AM -0400, John Ferlan wrote:
>> Add VIR_DOMAIN_BLOCK_IOTUNE*LENGTH and VIR_DOMAIN_TUNABLE_BLKDEV*LENGTH
>> parameters and their descriptions.
>>
>> Signed-off-by: John Ferlan <jferlan(a)redhat.com>
>> ---
>> Changes | 2 +-
>> Virt.xs | 12 ++++++++++++
>> lib/Sys/Virt/Domain.pm | 25 +++++++++++++++++++++++++
>> 3 files changed, 38 insertions(+), 1 deletion(-)
>>
>> diff --git a/Changes b/Changes
>> index 4985100..8d5683a 100644
>> --- a/Changes
>> +++ b/Changes
>> @@ -2,7 +2,7 @@ Revision history for perl module Sys::Virt
>>
>> 2.4.0 2016-00-00
>>
>> - - XXX
>> + - Add constants for the new block iotune parameters for length
>>
>> 2.3.0 2016-10-06
>>
>> diff --git a/Virt.xs b/Virt.xs
>> index b4ca049..88ed722 100644
>> --- a/Virt.xs
>> +++ b/Virt.xs
>> @@ -8275,6 +8275,12 @@ BOOT:
>> REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_READ_IOPS_SEC_MAX,
BLOCK_IOTUNE_READ_IOPS_SEC_MAX);
>> REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX,
BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX);
>> REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_SIZE_IOPS_SEC,
BLOCK_IOTUNE_SIZE_IOPS_SEC);
>> + REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_BYTES_SEC_MAX_LENGTH,
BLOCK_IOTUNE_TOTAL_BYTES_SEC_MAX_LENGTH);
>> + REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_READ_BYTES_SEC_MAX_LENGTH,
BLOCK_IOTUNE_READ_BYTES_SEC_MAX_LENGTH);
>> + REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_WRITE_BYTES_SEC_MAX_LENGTH,
BLOCK_IOTUNE_WRITE_BYTES_SEC_MAX_LENGTH);
>> + REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_IOPS_SEC_MAX_LENGTH,
BLOCK_IOTUNE_TOTAL_IOPS_SEC_MAX_LENGTH);
>> + REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_READ_IOPS_SEC_MAX_LENGTH,
BLOCK_IOTUNE_READ_IOPS_SEC_MAX_LENGTH);
>> + REGISTER_CONSTANT_STR(VIR_DOMAIN_BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX_LENGTH,
BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX_LENGTH);
>>
>>
>> REGISTER_CONSTANT(VIR_DOMAIN_BLOCK_RESIZE_BYTES, BLOCK_RESIZE_BYTES);
>> @@ -8484,6 +8490,12 @@ BOOT:
>> REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_BYTES_SEC_MAX,
TUNABLE_BLKDEV_TOTAL_BYTES_SEC_MAX);
>> REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_IOPS_SEC_MAX,
TUNABLE_BLKDEV_TOTAL_IOPS_SEC_MAX);
>> REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_SIZE_IOPS_SEC,
TUNABLE_BLKDEV_SIZE_IOPS_SEC);
>> +
REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_READ_BYTES_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_READ_BYTES_SEC_MAX_LENGTH);
>> + REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_READ_IOPS_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_READ_IOPS_SEC_MAX_LENGTH);
>> +
REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_WRITE_BYTES_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_WRITE_BYTES_SEC_MAX_LENGTH);
>> +
REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_WRITE_IOPS_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_WRITE_IOPS_SEC_MAX_LENGTH);
>> +
REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_BYTES_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_TOTAL_BYTES_SEC_MAX_LENGTH);
>> +
REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_IOPS_SEC_MAX_LENGTH,
TUNABLE_BLKDEV_TOTAL_IOPS_SEC_MAX_LENGTH);
>> REGISTER_CONSTANT_STR(VIR_DOMAIN_TUNABLE_CPU_IOTHREADSPIN,
TUNABLE_IOTHREADSPIN);
>
> You missed docs these this set of constants, so i'm suprised
> make test didn't complain
>
Oh right - forgot the second hunk... They're just a copy of the BLOCK
tunable anyway, so I copied and renamed the params to match the other
TUNABLE_BLKDEV defs in lib/Sys/Virt/Domain.pm:
Ok, ACK with that added
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
5:47 a.m.
New subject: [libvirt] [libvirt-perl PATCH 2/2] Add VIR_DOMAIN_VCPU_HOTPLUGGABLE
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
Changes | 1 +
Virt.xs | 1 +
lib/Sys/Virt/Domain.pm | 4 ++++
3 files changed, 6 insertions(+)
diff --git a/Changes b/Changes
index 8d5683a..897040b 100644
--- a/Changes
+++ b/Changes
@@ -3,6 +3,7 @@ Revision history for perl module Sys::Virt
2.4.0 2016-00-00
- Add constants for the new block iotune parameters for length
+ - Add VIR_DOMAIN_VCPU_HOTPLUGGABLE
2.3.0 2016-10-06
diff --git a/Virt.xs b/Virt.xs
index 88ed722..92f300b 100644
--- a/Virt.xs
+++ b/Virt.xs
@@ -8315,6 +8315,7 @@ BOOT:
REGISTER_CONSTANT(VIR_DOMAIN_VCPU_CONFIG, VCPU_CONFIG);
REGISTER_CONSTANT(VIR_DOMAIN_VCPU_MAXIMUM, VCPU_MAXIMUM);
REGISTER_CONSTANT(VIR_DOMAIN_VCPU_GUEST, VCPU_GUEST);
+ REGISTER_CONSTANT(VIR_DOMAIN_VCPU_HOTPLUGGABLE, VCPU_HOTPLUGGABLE);
REGISTER_CONSTANT(VIR_DOMAIN_SHUTDOWN_DEFAULT, SHUTDOWN_DEFAULT);
diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm
index 8bf4115..5e6669c 100644
--- a/lib/Sys/Virt/Domain.pm
+++ b/lib/Sys/Virt/Domain.pm
@@ -2793,6 +2793,10 @@ Flag to request adjustment of the maximum vCPU value
Flag to request the guest VCPU mask
+=item Sys::Virt::Domain::VCPU_GUEST_HOTPLUGGABLE
+
+Flag to request to make vcpus added hot(un)pluggable
+
=back
=head2 STATE CHANGE EVENTS
--
2.7.4
2946
days inactive
2946
days old
5 comments
2 participants
participants (2)
-
Daniel P. Berrange -
John Ferlan