Hi Tugdual!
Thanks for the patch series. I've applied and tested it and it's working
great!
Thanks again for the series. I've noted your major contribution in the
AUTHORS file
with big thanks going to you :-)
Michal
On 01/03/2013 10:34 AM, Tugdual Saunier wrote:
These patches are the result of my work to get libvirt-php compiled
under OS X.
As I suceeded to compiled it, I found some bugs/warnings
that are also fixed in the following commits.
The most important is probably the vnc_get_bitmap and vnc_refresh_screen now working.
Tugdual Saunier (20):
Fixed compilation under OS X
fixed a malloc_error_break in doc generation
fixed wrong xpath in domain type retrieving
fixed PHP warnings in uuid generation
fixed warnings
fixed resource counter changes in libvirt_list_active_domains
init array only if needed in libvirt_list_inactive_domains
fixed wrong maxsize type in libvirt_logfile_set
fixed wrong types in libvirt_check_version
fixed wrong byte_order determination under other OS by improving it
fixed wrong test on virConnectClose return value
fixed vnc_get_bitmap
Fixed infinite loop in vnc_refresh_screen
fixed last warnings
fixed doc generation under OSX
Made tests more universal by using libvirt test driver
reorder tests by dependency
improved test-install.phpt, no more need of a random name
fixed some segfault in test-domain-snapshot.phpt
fixed wrong doc alignment for libvirt_domain_managedsave
configure.ac | 10 +
docs/Makefile.am | 14 +-
src/Makefile.am | 5 +-
src/libvirt-php.c | 330 +++++++++++++--------------
src/libvirt-php.h | 16 +-
src/vncfunc.c | 25 +-
tests/data/example-no-disk-and-media.xml | 3 +-
tests/functions.phpt | 8 +
tests/php.ini | 2 +
tests/runtests.sh | 11 +-
tests/test-conn-limit.phpt | 2 +-
tests/test-connect.phpt | 40 +---
tests/test-domain-create-and-coredump.phpt | 2 +-
tests/test-domain-create-and-get-xpath.phpt | 4 +-
tests/test-domain-create.phpt | 2 +-
tests/test-domain-define-create-destroy.phpt | 2 +-
tests/test-domain-define-undefine.phpt | 2 +-
tests/test-domain-snapshot.phpt | 14 +-
tests/test-get-emulator.phpt | 10 +-
tests/test-install.phpt | 14 +-
tests/test-logging.phpt | 6 +-
tools/generate-api-docs.c | 1 +
22 files changed, 260 insertions(+), 263 deletions(-)
create mode 100644 tests/data/test-libvirt-php.img
create mode 100644 tests/php.ini
--
1.8.0.1
--
Michal Novotny <minovotn(a)redhat.com>, RHCE, Red Hat
Virtualization | libvirt-php bindings |
php-virt-control.org