On 05/01/2016 01:10 PM, Fritz Elfert wrote:
Hi, Cole Robinson asked me to post the attached patch here.
For more info, see
https://bugzilla.redhat.com/show_bug.cgi?id=1331552
Cheers
-Fritz
--
libvir-list mailing list
libvir-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Instead of sending as an attachment, please use 'git send-email', see
http://libvirt.org/hacking.html
I found that the patch doesn't compile:
make[3]: Entering directory '/home/jferlan/git/libvirt.work/src'
CC util/libvirt_util_la-viriscsi.lo
util/viriscsi.c: In function 'virISCSIScanTargets':
util/viriscsi.c:391:33: error: unused parameter 'initiatoriqn'
[-Werror=unused-parameter]
const char *initiatoriqn,
^
cc1: all warnings being treated as errors
That initiatoriqn is somewhat of a 'hidden' feature (I'm not sure I
could describe it well enough), but the XML that would be parsed is
something like:
<pool type="iscsi">
<name>multiiqn</name>
<source>
<host name="192.168.122.1"/>
<device path="iqn.2014-12.com.yy:server.target1"/>
<initiator>
<iqn name="iqn.2014-12.com.yy:server.target3"/>
</initiator>
</source>
<target>
<path>/dev/disk/by-path</path>
</target>
</pool>
The virISCSITargetAutologin call that you removed would add that to the
command line in 'virISCSIConnection()' as an '--interface' parameter.
So the question becomes is it necessary? If not, then there's some more
work to remove it since a few virISCSIScanTargets() callers expect to
pass it. If so, then something would need to be added to the ISCSIADM
command in virISCSIScanTargets to add that.
In either case, a v2 is going to be needed.
Tks -
John