[libvirt] [PATCH] maint: fix line numbers in check-aclrules reports
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
Reset line numbering on each input file in check-aclrules.pl. Otherwise
it reports wrong line numbers in its error messages.
Signed-off-by: Yuri Myasoedov <ymyasoedov(a)yandex.ru>
---
src/check-aclrules.pl | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/check-aclrules.pl b/src/check-aclrules.pl
index f54b934..9151e6a 100755
--- a/src/check-aclrules.pl
+++ b/src/check-aclrules.pl
@@ -254,6 +254,8 @@ while (<>) {
$brace += $count;
$count = s/}//g;
$brace -= $count;
+} continue {
+ close ARGV if eof;
}
exit $status;
--
1.8.4.3
On 02/09/2014 01:10 PM, Roman Bogorodskiy wrote:
Reset line numbering on each input file in check-aclrules.pl.
Otherwise
it reports wrong line numbers in its error messages.
Signed-off-by: Yuri Myasoedov <ymyasoedov(a)yandex.ru>
Generally, we like to preserve git authorship to the original patch
idea. Based on IRC, I clarified that Yuri wrote the patch, then Roman
tested it. I was able to reproduce the bogus line numbers by deleting a
line from qemuConnectGetType (currently line 1137 of qemu_driver.c),
pre-patch the error complained about line 104704 (that's a lot of
lines!), post-patch, it complained about 16501 (the line where
qemuConnectGetType is registered as a driver callback function pointer).
ACK and pushed with authorship fixed up. Congrats, Yuri, on your first
patch, even if it took an indirect route into the tree :)
---
src/check-aclrules.pl | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/check-aclrules.pl b/src/check-aclrules.pl
index f54b934..9151e6a 100755
--- a/src/check-aclrules.pl
+++ b/src/check-aclrules.pl
@@ -254,6 +254,8 @@ while (<>) {
$brace += $count;
$count = s/}//g;
$brace -= $count;
+} continue {
+ close ARGV if eof;
}
exit $status;
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
3939
days inactive
3940
days old
1 comments
2 participants
tags (0)
participants (2)
-
Eric Blake -
Roman Bogorodskiy