On 04/05/2010 11:37 AM, Chris Lalancette wrote: > Signed-off-by: Chris Lalancette <clalance(a)redhat.com&gt; > --- > tools/virsh.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/tools/virsh.c b/tools/virsh.c > index ad64bc0..d241fa0 100644 > --- a/tools/virsh.c > +++ b/tools/virsh.c > @@ -2407,7 +2407,8 @@ cmdSetmem(vshControl *ctl, const vshCmd *cmd) > > if (kilobytes > info.maxMem) { > virDomainFree(dom); > - vshError(ctl, _("Invalid value of %d for memory size"), kilobytes); > + vshError(ctl, _("Requested memory size %d kb is larger than maximum of %lu kb"), > + kilobytes, info.maxMem); ACK to the wording change. But why is kilobytes int, while info.maxMem is unsigned long? Could that ever bite us when converting 32-bit kilobytes to 64-bit unsigned?