7:09 a.m.
Ján Tomko (3):
virsh: clean up includes
conf: remove outdated comment
conf: remove reference to VIR_DOMAIN_RNG_BACKEND_POOL
src/conf/domain_conf.h | 2 --
tools/virsh.c | 3 ---
tools/vsh.c | 3 ---
3 files changed, 8 deletions(-)
--
2.19.2
7:09 a.m.
New subject: [libvirt] [PATCH 1/3] virsh: clean up includes
We don't need domain_conf or libvirt-{qemu,lxc} in these generic files.
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
tools/virsh.c | 3 ---
tools/vsh.c | 3 ---
2 files changed, 6 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index b41304a888..c758e38cbd 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -40,12 +40,9 @@
#include "virerror.h"
#include "virbuffer.h"
#include "viralloc.h"
-#include <libvirt/libvirt-qemu.h>
-#include <libvirt/libvirt-lxc.h>
#include "virfile.h"
#include "virthread.h"
#include "vircommand.h"
-#include "conf/domain_conf.h"
#include "virtypedparam.h"
#include "virstring.h"
#include "virgettext.h"
diff --git a/tools/vsh.c b/tools/vsh.c
index f2486498c9..5de082cb34 100644
--- a/tools/vsh.c
+++ b/tools/vsh.c
@@ -41,12 +41,9 @@
#include "virerror.h"
#include "virbuffer.h"
#include "viralloc.h"
-#include <libvirt/libvirt-qemu.h>
-#include <libvirt/libvirt-lxc.h>
#include "virfile.h"
#include "virthread.h"
#include "vircommand.h"
-#include "conf/domain_conf.h"
#include "virtypedparam.h"
#include "virstring.h"
--
2.19.2
7:43 a.m.
New subject: [libvirt] [PATCH 1/3] virsh: clean up includes
On Thu, Jul 25, 2019 at 14:09:10 +0200, Ján Tomko wrote:
We don't need domain_conf or libvirt-{qemu,lxc} in these generic
files.
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
tools/virsh.c | 3 ---
tools/vsh.c | 3 ---
2 files changed, 6 deletions(-)
ACK
7:09 a.m.
New subject: [libvirt] [PATCH 2/3] conf: remove outdated comment
When using the ENUM macros, the compiler guards that the declaration
and implementation are in sync.
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
src/conf/domain_conf.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index 48b0af4b04..00ff734ff0 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -119,7 +119,6 @@ struct _virDomainDeviceDef {
};
/* Different types of hypervisor */
-/* NB: Keep in sync with virDomainVirtTypeToString impl */
typedef enum {
VIR_DOMAIN_VIRT_NONE = 0,
VIR_DOMAIN_VIRT_QEMU,
--
2.19.2
7:44 a.m.
New subject: [libvirt] [PATCH 2/3] conf: remove outdated comment
On Thu, Jul 25, 2019 at 14:09:11 +0200, Ján Tomko wrote:
When using the ENUM macros, the compiler guards that the declaration
and implementation are in sync.
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
src/conf/domain_conf.h | 1 -
1 file changed, 1 deletion(-)
ACK
7:09 a.m.
New subject: [libvirt] [PATCH 3/3] conf: remove reference to VIR_DOMAIN_RNG_BACKEND_POOL
Sadly, this brilliant idea never got implemented:
https://www.fit.vutbr.cz/study/DP/DP.php.en?id=14418
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
src/conf/domain_conf.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index 00ff734ff0..822f9af265 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -2075,7 +2075,6 @@ typedef enum {
typedef enum {
VIR_DOMAIN_RNG_BACKEND_RANDOM,
VIR_DOMAIN_RNG_BACKEND_EGD,
- /* VIR_DOMAIN_RNG_BACKEND_POOL, */
VIR_DOMAIN_RNG_BACKEND_LAST
} virDomainRNGBackend;
--
2.19.2
7:41 a.m.
New subject: [libvirt] [PATCH 3/3] conf: remove reference to VIR_DOMAIN_RNG_BACKEND_POOL
On Thu, Jul 25, 2019 at 14:09:12 +0200, Ján Tomko wrote:
Sadly, this brilliant idea never got implemented:
https://www.fit.vutbr.cz/study/DP/DP.php.en?id=14418
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
ACK if you remove the irrelevant forgotten history from the commit message.
2062
days inactive
2062
days old
6 comments
2 participants
participants (2)
-
Ján Tomko -
Peter Krempa