[libvirt] [libvirt-glib] libvirt-gconfig: Move symbols introduced post 0.0.4 to the correct versions
3:31 p.m.
Triggered by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667683
---
If this looks correct I'll have a look at libvirt-glib and
libvirt-gobject too.
-- Guido
libvirt-gconfig/libvirt-gconfig.sym | 50 +++++++++++++++++++++++------------
1 files changed, 33 insertions(+), 17 deletions(-)
diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym
index 717c3c9..405ad98 100644
--- a/libvirt-gconfig/libvirt-gconfig.sym
+++ b/libvirt-gconfig/libvirt-gconfig.sym
@@ -14,10 +14,6 @@ LIBVIRT_GCONFIG_0.0.4 {
gvir_config_domain_new;
gvir_config_domain_new_from_xml;
gvir_config_domain_set_clock;
- gvir_config_domain_set_custom_xml;
- gvir_config_domain_get_custom_xml;
- gvir_config_domain_get_description;
- gvir_config_domain_set_description;
gvir_config_domain_get_devices;
gvir_config_domain_set_devices;
gvir_config_domain_get_features;
@@ -51,10 +47,6 @@ LIBVIRT_GCONFIG_0.0.4 {
gvir_config_domain_chardev_source_pty_new_from_xml;
gvir_config_domain_source_pty_set_path;
- gvir_config_domain_chardev_source_spicevmc_get_type;
- gvir_config_domain_chardev_source_spicevmc_new;
- gvir_config_domain_chardev_source_spicevmc_new_from_xml;
-
gvir_config_domain_clock_get_type;
gvir_config_domain_clock_offset_get_type;
gvir_config_domain_clock_new;
@@ -79,8 +71,6 @@ LIBVIRT_GCONFIG_0.0.4 {
gvir_config_domain_disk_type_get_type;
gvir_config_domain_disk_new;
gvir_config_domain_disk_new_from_xml;
- gvir_config_domain_disk_get_driver_cache;
- gvir_config_domain_disk_set_driver_cache;
gvir_config_domain_disk_get_driver_name;
gvir_config_domain_disk_set_driver_name;
gvir_config_domain_disk_get_driver_type;
@@ -96,7 +86,6 @@ LIBVIRT_GCONFIG_0.0.4 {
gvir_config_domain_disk_get_target_dev;
gvir_config_domain_disk_set_target_dev;
gvir_config_domain_disk_get_disk_type;
- gvir_config_domain_disk_set_readonly;
gvir_config_domain_disk_set_type;
gvir_config_domain_filesys_get_type;
@@ -146,13 +135,9 @@ LIBVIRT_GCONFIG_0.0.4 {
gvir_config_domain_interface_get_type;
gvir_config_domain_interface_link_state_get_type;
gvir_config_domain_interface_set_ifname;
- gvir_config_domain_interface_get_ifname;
gvir_config_domain_interface_set_link_state;
- gvir_config_domain_interface_get_link_state;
gvir_config_domain_interface_set_mac;
- gvir_config_domain_interface_get_mac;
gvir_config_domain_interface_set_model;
- gvir_config_domain_interface_get_model;
gvir_config_domain_interface_bridge_get_type;
gvir_config_domain_interface_bridge_new;
@@ -327,8 +312,39 @@ LIBVIRT_GCONFIG_0.0.4 {
gvir_config_xml_doc_get_type;
gvir_config_xml_doc_new;
- local:
- *;
};
+LIBVIRT_GCONFIG_0.0.5 {
+ global:
+ gvir_config_domain_disk_get_driver_cache;
+ gvir_config_domain_disk_set_driver_cache;
+
+ gvir_config_domain_disk_set_readonly;
+
+ gvir_config_domain_set_custom_xml;
+ gvir_config_domain_get_custom_xml;
+ gvir_config_domain_get_description;
+ gvir_config_domain_set_description;
+} LIBVIRT_GCONFIG_0.0.4;
+
+LIBVIRT_GCONFIG_0.0.6 {
+ global:
+ gvir_config_domain_interface_get_ifname;
+ gvir_config_domain_interface_get_link_state;
+ gvir_config_domain_interface_get_mac;
+ gvir_config_domain_interface_get_model;
+} LIBVIRT_GCONFIG_0.0.5;
+
+LIBVIRT_GCONFIG_0.0.7 {
+ global:
+ gvir_config_domain_chardev_source_spicevmc_get_type;
+ gvir_config_domain_chardev_source_spicevmc_new;
+ gvir_config_domain_chardev_source_spicevmc_new_from_xml;
+} LIBVIRT_GCONFIG_0.0.6;
+
# .... define new API here using predicted next version number ....
+
+LIBVIRT_GCONFIG_PRIVATE_0.0.7 {
+ local:
+ *;
+};
--
1.7.9.1
3:38 p.m.
On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote:
Triggered by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667683
---
If this looks correct I'll have a look at libvirt-glib and
libvirt-gobject too.
Doing this would break ABI. We should just make sure future symbols
are added in the right place
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
3:47 a.m.
Hey,
On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote:
On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote:
> Triggered by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667683
> ---
> If this looks correct I'll have a look at libvirt-glib and
> libvirt-gobject too.
Doing this would break ABI. We should just make sure future symbols
are added in the right place
I thought that until we decide we'll attempt to be ABI stable, we'd be
raising the symbols version number before every release if there has been
any new symbols, thus breaking ABI. It seems this hasn't been done in a
while :-/
Christophe
4:24 a.m.
On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote:
Hey,
On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote:
> On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote:
> > Triggered by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667683
> > ---
> > If this looks correct I'll have a look at libvirt-glib and
> > libvirt-gobject too.
>
> Doing this would break ABI. We should just make sure future symbols
> are added in the right place
I thought that until we decide we'll attempt to be ABI stable, we'd be
raising the symbols version number before every release if there has been
any new symbols, thus breaking ABI. It seems this hasn't been done in a
while :-/
Oh wait yes. I was getting mixed up with libosinfo, which we decided was
ABI stable. We can still update libvirt-glib
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
6:23 a.m.
On Wed, Apr 11, 2012 at 10:24:42AM +0100, Daniel P. Berrange wrote:
On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote:
> Hey,
>
> On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote:
> > On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote:
> > > Triggered by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667683
> > > ---
> > > If this looks correct I'll have a look at libvirt-glib and
> > > libvirt-gobject too.
> >
> > Doing this would break ABI. We should just make sure future symbols
> > are added in the right place
>
> I thought that until we decide we'll attempt to be ABI stable, we'd be
> raising the symbols version number before every release if there has been
> any new symbols, thus breaking ABI. It seems this hasn't been done in a
> while :-/
Oh wait yes. I was getting mixed up with libosinfo, which we decided was
ABI stable. We can still update libvirt-glib
Maybe we could start paying attention to symbol versioning, and raise
soname when we really break ABI
Christophe
6:25 a.m.
On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote:
Hey,
On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote:
> On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote:
> > Triggered by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667683
> > ---
> > If this looks correct I'll have a look at libvirt-glib and
> > libvirt-gobject too.
>
> Doing this would break ABI. We should just make sure future symbols
> are added in the right place
I thought that until we decide we'll attempt to be ABI stable, we'd be
raising the symbols version number before every release if there has been
any new symbols, thus breaking ABI. It seems this hasn't been done in a
while :-/
So what about the attached patch. 0.0.8 didn't introduce new symbols yet
so I went for 0.0.7.
Cheers,
-- Guido
6:30 a.m.
On Wed, Apr 11, 2012 at 01:25:45PM +0200, Guido Günther wrote:
On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote:
> Hey,
>
> On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote:
> > On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote:
> > > Triggered by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667683
> > > ---
> > > If this looks correct I'll have a look at libvirt-glib and
> > > libvirt-gobject too.
> >
> > Doing this would break ABI. We should just make sure future symbols
> > are added in the right place
>
> I thought that until we decide we'll attempt to be ABI stable, we'd be
> raising the symbols version number before every release if there has been
> any new symbols, thus breaking ABI. It seems this hasn't been done in a
> while :-/
So what about the attached patch. 0.0.8 didn't introduce new symbols yet
so I went for 0.0.7.
From 1ad4c24bdb93f57f14f34067ecdfea129751f6d4 Mon Sep 17 00:00:00
2001
From: =?UTF-8?q?Guido=20G=C3=BCnther?= <agx(a)sigxcpu.org>
Date: Wed, 11 Apr 2012 13:17:00 +0200
Subject: [libvirt-glib] Raise symbol version number
since new symbols were introduced since 0.0.4
---
libvirt-gconfig/libvirt-gconfig.sym | 2 +-
libvirt-glib/libvirt-glib.sym | 2 +-
libvirt-gobject/libvirt-gobject.sym | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym
index 717c3c9..2378a3c 100644
--- a/libvirt-gconfig/libvirt-gconfig.sym
+++ b/libvirt-gconfig/libvirt-gconfig.sym
@@ -1,4 +1,4 @@
-LIBVIRT_GCONFIG_0.0.4 {
+LIBVIRT_GCONFIG_0.0.7 {
global:
gvir_config_init_check;
gvir_config_init;
diff --git a/libvirt-glib/libvirt-glib.sym b/libvirt-glib/libvirt-glib.sym
index bb8fa34..53b8907 100644
--- a/libvirt-glib/libvirt-glib.sym
+++ b/libvirt-glib/libvirt-glib.sym
@@ -1,4 +1,4 @@
-LIBVIRT_GLIB_0.0.4 {
+LIBVIRT_GLIB_0.0.7 {
global:
gvir_init;
gvir_init_check;
diff --git a/libvirt-gobject/libvirt-gobject.sym b/libvirt-gobject/libvirt-gobject.sym
index 460280b..64c91cc 100644
--- a/libvirt-gobject/libvirt-gobject.sym
+++ b/libvirt-gobject/libvirt-gobject.sym
@@ -1,4 +1,4 @@
-LIBVIRT_GOBJECT_0.0.4 {
+LIBVIRT_GOBJECT_0.0.7 {
global:
gvir_init_object;
gvir_init_object_check;
ACK
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
9:26 a.m.
On Wed, Apr 11, 2012 at 12:30:05PM +0100, Daniel P. Berrange wrote:
On Wed, Apr 11, 2012 at 01:25:45PM +0200, Guido Günther wrote:
> On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote:
> > Hey,
> >
> > On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote:
> > > On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote:
> > > > Triggered by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667683
> > > > ---
> > > > If this looks correct I'll have a look at libvirt-glib and
> > > > libvirt-gobject too.
> > >
> > > Doing this would break ABI. We should just make sure future symbols
> > > are added in the right place
> >
> > I thought that until we decide we'll attempt to be ABI stable, we'd be
> > raising the symbols version number before every release if there has been
> > any new symbols, thus breaking ABI. It seems this hasn't been done in a
> > while :-/
>
> So what about the attached patch. 0.0.8 didn't introduce new symbols yet
> so I went for 0.0.7.
> From 1ad4c24bdb93f57f14f34067ecdfea129751f6d4 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Guido=20G=C3=BCnther?= <agx(a)sigxcpu.org>
> Date: Wed, 11 Apr 2012 13:17:00 +0200
> Subject: [libvirt-glib] Raise symbol version number
>
> since new symbols were introduced since 0.0.4
> ---
> libvirt-gconfig/libvirt-gconfig.sym | 2 +-
> libvirt-glib/libvirt-glib.sym | 2 +-
> libvirt-gobject/libvirt-gobject.sym | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libvirt-gconfig/libvirt-gconfig.sym
b/libvirt-gconfig/libvirt-gconfig.sym
> index 717c3c9..2378a3c 100644
> --- a/libvirt-gconfig/libvirt-gconfig.sym
> +++ b/libvirt-gconfig/libvirt-gconfig.sym
> @@ -1,4 +1,4 @@
> -LIBVIRT_GCONFIG_0.0.4 {
> +LIBVIRT_GCONFIG_0.0.7 {
> global:
> gvir_config_init_check;
> gvir_config_init;
> diff --git a/libvirt-glib/libvirt-glib.sym b/libvirt-glib/libvirt-glib.sym
> index bb8fa34..53b8907 100644
> --- a/libvirt-glib/libvirt-glib.sym
> +++ b/libvirt-glib/libvirt-glib.sym
> @@ -1,4 +1,4 @@
> -LIBVIRT_GLIB_0.0.4 {
> +LIBVIRT_GLIB_0.0.7 {
> global:
> gvir_init;
> gvir_init_check;
> diff --git a/libvirt-gobject/libvirt-gobject.sym
b/libvirt-gobject/libvirt-gobject.sym
> index 460280b..64c91cc 100644
> --- a/libvirt-gobject/libvirt-gobject.sym
> +++ b/libvirt-gobject/libvirt-gobject.sym
> @@ -1,4 +1,4 @@
> -LIBVIRT_GOBJECT_0.0.4 {
> +LIBVIRT_GOBJECT_0.0.7 {
> global:
> gvir_init_object;
> gvir_init_object_check;
ACK
Pushed. Thanks,
-- Guido
6:41 a.m.
On Wed, Apr 11, 2012 at 01:25:45PM +0200, Guido Günther wrote:
On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote:
> Hey,
>
> On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote:
> > On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote:
> > > Triggered by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667683
> > > ---
> > > If this looks correct I'll have a look at libvirt-glib and
> > > libvirt-gobject too.
> >
> > Doing this would break ABI. We should just make sure future symbols
> > are added in the right place
>
> I thought that until we decide we'll attempt to be ABI stable, we'd be
> raising the symbols version number before every release if there has been
> any new symbols, thus breaking ABI. It seems this hasn't been done in a
> while :-/
So what about the attached patch. 0.0.8 didn't introduce new symbols yet
so I went for 0.0.7.
I'd go for 0.0.8 since I hope to get my usb redir patch series which adds
new libvirt-gconfig symbols, and this way we won't forget to raise this
number ;) Or I can add a patch going from 0.0.7 to 0.0.8 in the series.
Christophe
9:26 a.m.
On Wed, Apr 11, 2012 at 01:41:38PM +0200, Christophe Fergeau wrote:
On Wed, Apr 11, 2012 at 01:25:45PM +0200, Guido Günther wrote:
> On Wed, Apr 11, 2012 at 10:47:46AM +0200, Christophe Fergeau wrote:
> > Hey,
> >
> > On Tue, Apr 10, 2012 at 09:38:36PM +0100, Daniel P. Berrange wrote:
> > > On Tue, Apr 10, 2012 at 10:31:55PM +0200, Guido Günther wrote:
> > > > Triggered by http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667683
> > > > ---
> > > > If this looks correct I'll have a look at libvirt-glib and
> > > > libvirt-gobject too.
> > >
> > > Doing this would break ABI. We should just make sure future symbols
> > > are added in the right place
> >
> > I thought that until we decide we'll attempt to be ABI stable, we'd be
> > raising the symbols version number before every release if there has been
> > any new symbols, thus breaking ABI. It seems this hasn't been done in a
> > while :-/
>
> So what about the attached patch. 0.0.8 didn't introduce new symbols yet
> so I went for 0.0.7.
I'd go for 0.0.8 since I hope to get my usb redir patch series which adds
new libvirt-gconfig symbols, and this way we won't forget to raise this
number ;) Or I can add a patch going from 0.0.7 to 0.0.8 in the series.
I think that would be best since we'd start tracking ABI changes this
way.
Cheers,
-- Guido
4608
days inactive
4609
days old
9 comments
3 participants
participants (3)
-
Christophe Fergeau -
Daniel P. Berrange -
Guido Günther