11:35 p.m.
Hi, Rich
Fix trailing blanks.
http://builder.virt-manager.org/module-libvirt--devel.html
Thanks
Atsushi SAKAI
3:08 a.m.
On Thu, May 29, 2008 at 01:35:55PM +0900, Atsushi SAKAI wrote:
Hi, Rich
Fix trailing blanks.
http://builder.virt-manager.org/module-libvirt--devel.html
+1 , please push the fix,
thanks !
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
3:26 a.m.
Hi, Daniel
Thank you.
I already commited.
By the way, Test-AutoBuild is great tool ,
since it generates RSS for failed module only.
Thanks
Atsushi SAKAI
Daniel Veillard <veillard(a)redhat.com> wrote:
On Thu, May 29, 2008 at 01:35:55PM +0900, Atsushi SAKAI wrote:
> Hi, Rich
>
> Fix trailing blanks.
>
> http://builder.virt-manager.org/module-libvirt--devel.html
+1 , please push the fix,
thanks !
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
9:57 a.m.
On Thu, May 29, 2008 at 01:35:55PM +0900, Atsushi SAKAI wrote:
Hi, Rich
Fix trailing blanks.
This patch broke the test suite - the virsh command was generating data
with trailing blanks.
So I've added the following patch too, which stops it generating blanks
Dan.
Index: src/virsh.c
===================================================================
RCS file: /data/cvs/libvirt/src/virsh.c,v
retrieving revision 1.154
diff -u -p -r1.154 virsh.c
--- src/virsh.c 27 May 2008 09:41:26 -0000 1.154
+++ src/virsh.c 29 May 2008 14:54:35 -0000
@@ -1535,7 +1535,7 @@ cmdDominfo(vshControl * ctl, vshCmd * cm
vshPrint(ctl, "%-15s %lu kB\n", _("Max memory:"),
info.maxMem);
else
- vshPrint(ctl, "%-15s %-15s\n", _("Max memory:"),
+ vshPrint(ctl, "%-15s %s\n", _("Max memory:"),
_("no limit"));
vshPrint(ctl, "%-15s %lu kB\n", _("Used memory:"),
@@ -1546,7 +1546,7 @@ cmdDominfo(vshControl * ctl, vshCmd * cm
}
if (!virDomainGetAutostart(dom, &autostart)) {
- vshPrint(ctl, "%-15s %-15s\n", _("Autostart:"),
+ vshPrint(ctl, "%-15s %s\n", _("Autostart:"),
autostart ? _("enable") : _("disable") );
}
--
|: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
6021
days inactive
6021
days old
3 comments
3 participants
participants (3)
-
Atsushi SAKAI -
Daniel P. Berrange -
Daniel Veillard