Re: [libvirt] [PATCH v3 01/11] Add QMP probing for TPM

On 04/01/2013 03:45 PM, Corey Bryant wrote: >> + if (ret < 0) >> + goto cleanup; >> + >> + ret = -1; >> + >> + if (!(data = virJSONValueObjectGet(reply, "return"))) { >> + virReportError(VIR_ERR_INTERNAL_ERROR, >> + _("%s reply was missing return data"), >> + qmpCmd); >> + goto cleanup; >> + } >> +

>> +cleanup: >> + if (ret < 0) >> + virStringFreeList(list); >> + virJSONValueFree(cmd); >> + virJSONValueFree(reply); > + > > Does data need to be freed? > It doesn't seem to be the case for the 'return' object. No other code frees it, either.