Re: Please explain to me this commit
On 10/14/21 12:16 PM, Ani Sinha wrote:
https://gitlab.com/libvirt/libvirt/-/commit/bdc3e8f47be108fa552b72a6d9135...
<https://gitlab.com/libvirt/libvirt/-/commit/bdc3e8f47be108fa552b72a6d9135...
I think you completely missed the logic here and you are rewriting a
patch without cc'ing the original author. I'm sorry but this is rude.
For acpi-bridge hotplug some conditions have to be met. If the guest
uses q35 then QEMU_CAPS_ICH9_ACPI_HOTPLUG_BRIDGE capability has to be
set, or if guest is i440fx then the QEMU_CAPS_PIIX4_ACPI_HOTPLUG_BRIDGE
capability has to be set.
Previously, the code did not check for the i440fx case at all.
Michal