Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

On Thu, Jul 09, 2015 at 02:41:45PM +0100, Zeeshan Ali (Khattak) wrote: > The answer was that magnitude of ugliness is irrelevant. Surely you > know that this is not anything objective. To me a single #ifdef is > ugly enough but seems it's not for you so how do you expect either of > us to convince each other with arguments? If you really need something > more concrete, I see at least 12 #ifdefs needed. Pretty ugly for my > taste at least. I'm just trying to have a discussion about something concrete. If just one #ifdef was needed, I guess you'll bear with me if I try to convince you to go this way, with 12 #ifdef, you've got a more understandable standing in opposing this. > > > Quite > > hard to make a decision with so few details ;) > > All needed "details" are avaiable and it's only a matter of taste and > amount of care we want to give to distros. Both are subjective > matters. Same deal as with the amount of #ifdef needed, if only EL6 has a too old libvirt, then you are in a much better position to convince me than if Debian stable and latest Ubuntu (making things up) have a too old libvirt. Ie let's know the exact tradeoffs we are discussing here from a technical point of view, maybe we won't have to agree to disagree and look for a tie breaker ;)