Re: [PATCH v2 5/9] qapi: Generalize struct member policy checking
Juan Quintela <quintela(a)redhat.com> writes:
Markus Armbruster <armbru(a)redhat.com> wrote:
> The generated visitor functions call visit_deprecated_accept() and
> visit_deprecated() when visiting a struct member with special feature
> flag 'deprecated'. This makes the feature flag visible to the actual
> visitors. I want to make feature flag 'unstable' visible there as
> well, so I can add policy for it.
>
> To let me make it visible, replace these functions by
> visit_policy_reject() and visit_policy_skip(), which take the member's
> special features as an argument. Note that the new functions have the
> opposite sense, i.e. the return value flips.
>
> Signed-off-by: Markus Armbruster <armbru(a)redhat.com>
Reviewed-by: Juan Quintela <quintela(a)redhat.com>
Reversing accept/reject make things "interesting" for a review point of view.
Sorry about that.
> + * @special_features is the member's special features
encoded as a
> + * bitset of QapiSpecialFeature.
Just to nitty pick, if you rename the variable to features, does the
sentece is clearer?
Not to me, I'm afraid...
Thanks!