Re: [libvirt] [PATCH 10/16] openvz: Convert virExec usage to virCommand

11 May 2011


      On 05/10/2011 02:07 PM, Cole Robinson wrote:
...
+    virCommandPtr cmd = virCommandNewArgList(VZLIST, "-ovpsid", "-H" , NULL);
+
+    virCommandSetOutputFD(cmd, &outfd);
+    if (virCommandRunAsync(cmd, &pid) < 0)
+        goto cleanup;
while (got < nids) {
         ret = openvz_readline(outfd, buf, 32);
@@ -1405,13 +1402,20 @@ static int openvzListDomains(virConnectPtr conn ATTRIBUTE_UNUSED,
         ids[got] = veid;
         got ++;
     }
-    waitpid(pid, NULL, 0);
+
+    if (virCommandWait(cmd, NULL) < 0)
+        goto cleanup;
Another case where passing NULL for pid is probably simpler.

-- 
Eric Blake   eblake@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

    