Re: [libvirt] [PATCH] storage: expose volume meta-type in XML

On 23/11/13 06:26, Eric Blake wrote: > I got annoyed at having to use both 'virsh vol-list $pool --details' > AND 'virsh vol-dumpxml $vol $pool' to learn if I had populated > the volume correctly. Since two-thirds of the data present in > virStorageVolGetInfo() already appears in virStorageVolGetXMLDesc(), > this just adds the remaining piece of information. > > * docs/formatstorage.html.in: Document new <target type=...>. I didn't see it relates with "target". > * docs/schemas/storagevol.rng (target, backingStore): Add it to > RelaxNG. I thought "(target, backingStore)" means add "type" to both of them. Finally see it means "between" :-)

> + <dt><code>type</code></dt> > + <dd>Output-only; provides the volume type that is also available > + from <code>virStorageVolGetInfo()</code>. <span > class="since">Since I think it's better to mention "virsh vol-list $pool --details" instead of the API name here, as we did across the documents. I'm fine if you keep it though.

> > +VIR_ENUM_IMPL(virStorageVol, > + VIR_STORAGE_VOL_LAST, > + "file", "block", "dir", "network") Here the "network-dir" type is not included though. So I guess you want to push this patch before the glusterfs series. ACK if the "network-dir" is removed.