Re: [libvirt] [PATCH 4/6] virsh: Create macro for "overwrite" and no-overwrite" options
[...]
>
> So then in your opinion and using the same logic, patch 3 is also nixed?
> This one will get used in patch 6.
With that use it will result in total 4 uses. I won't object if you fix
the macro name and remove the comma
Hmm. by name change do you mean "OPT_POOL_FILE_COMMON",
"OPT_POOL_OVERWRITE_COMMON", etc.? I guess I was thinking less globally
available macros, e.g. module specific rather than adding them to some
more generally included virsh*.h file.
Patch 3 attempts to create a universal macro for any "file"
option, but
that can't be really done universally. See for yourself:
git grep -A 4 '\.name = "file"'
Yeah - 'file' is one of those that isn't universal for all virsh*.c files.
This started out of a desire to not copy all the opts_pool_X_as options
as was done by Osier in his initial changes (see link in cover) for
pool-create-as and pool-define-as.
Then I thought - oh we have so many duplicated elements, why not
generate module specific macros to handle.
John
The name of the macro would really need to be specific for pool XML
file
name. Any other attempt will create confusion and I don't think it's
worth.
>
> Like I noted in the cover letter - I see value in having the macros and
> I also see the pain (having to go look them up).
>
> Adjusting the changes to remove/use commas is fine - just made the
> initial cut-n-paste easier
>
> John