Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system
On Tue, Sep 17, 2019 at 5:22 PM Pavel Hrdina <phrdina(a)redhat.com> wrote:
Meson build system is simple and quick compared to Autotools and it's
able to fully replace our Autotools usage. There are few drawbacks as
it's a fairly new build system, it requires Python 3.5 and Ninja 1.5.0,
it's still evolving and the user base is not that large and there were
some tweaks required to achieve the same functionality.
However, there are benefits, the configure and build time is way shorter
and build definition files are more readable and easier to maintain.
Hmm. I really would prefer smaller patches.
- Add meson;
- Drop autotools;
- Change spec files;
- ...
I didn't go through the patch, will do that in the next days ... but a
few things should be considered here:
- meson >= 0.49.0 basically means the project won't be built on Debian
< 10, Ubuntu < 19.04 ... which may be a problem for the project, if
you're following libvirt supported distros;
- please, take a look at the work done on libvirt-jenkins-ci and try
to adapt this one to follow the targets we have there;
- It'll force the addition of a `ninja syntax-check`, instead of
having the syntax-check as part of the tests;
Again, I'll carefully go through this patch in the next days.
Best Regards,
--
Fabiano Fidêncio