Re: [libvirt] patch: allow disk cache mode to be specified in a domain's xml definition.

"Daniel P. Berrange" <berrange(a)redhat.com&gt; wrote: ... > Further up in this code its already adding cache=off for shared disks. Probably introduced by me in the merge. > There's also quite a few code style issues, not following conventions > of the surrounding code. > > Here's a patch which addresses all that, and more importantly adds test > cases covering all the cache variants QEMU has. > > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-none.args | 1 > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-none.xml | 29 +++++++ > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-wb.args | 1 > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-wb.xml | 29 +++++++ > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-wt.args | 1 > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-wt.xml | 29 +++++++ > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-none.args | 1 > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-none.xml | 29 +++++++ > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wb.args | 1 > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wb.xml | 29 +++++++ > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wt.args | 1 > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wt.xml | 29 +++++++ > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.args | 1 > b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.xml | 30 +++++++ I looked through the incremental changes, and they look ok, but see that they do introduce new test failures: