Re: [libvirt] [PATCH] syntax-check: check QEMU caps grouping
On 04/12/2018 03:40 AM, Ján Tomko wrote:
Introduce a perl script that is able to regroup both
the QEMU_CAPS constants and the capability strings.
Check correct grouping as a part of syntax check.
For in-place regrouping after a rebase, just run:
tests/group-qemu-caps.pl
without any parameters.
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
cfg.mk | 5 +-
src/qemu/qemu_capabilities.h | 2 +-
tests/group-qemu-caps.pl | 118 +++++++++++++++++++++++++++++++++++++++++++
3 files changed, 123 insertions(+), 2 deletions(-)
create mode 100755 tests/group-qemu-caps.pl
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John
Not my area of expertise, but I assume you use this and it looks useful
to reduce code review tasks on capabilities files. One less thing to
think about as long as someone runs syntax-check before posting patches.