Re: [libvirt] [PATCH] libvirt-guests: wait for ntp service
Michal Privoznik wrote:
On 08.09.2014 18:30, Jim Fehlig wrote:
> If an NTP server is configured on the host, it is possible for
> libvirt-guests to start before the NTP service, in which case
> guest clocks won't be synchronized to the host clock.
>
> Add ntp-wait.service to "After" in libvirt-guests systemd service
> file, ensuring NTP has synchronized the host clock before starting
> any guests.
>
> Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
> ---
> tools/libvirt-guests.service.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libvirt-guests.service.in
> b/tools/libvirt-guests.service.in
> index d8d7adf..226b3bd 100644
> --- a/tools/libvirt-guests.service.in
> +++ b/tools/libvirt-guests.service.in
> @@ -1,6 +1,6 @@
> [Unit]
> Description=Suspend Active Libvirt Guests
> -After=network.target libvirtd.service
> +After=network.target libvirtd.service ntp-wait.service
> Documentation=man:libvirtd(8)
> Documentation=http://libvirt.org
>
>
Well, guest can have their own ntp-client (and in most cases they do,
right?).
I think most do, but know of at least two users who want to use kvmclock
with no ntp in the guests :).
I mean, since guests can be paused, saved & restored back, their
time
is often off. So the best is to have an ntp-client running inside the
guest.
Yep. I mentioned this, but seems they don't use save, restore, migrate,
et. al., since it wasn't a concern. But I'm fine handling this
downstream. Thanks!
Regards,
Jim