Re: [libvirt] [PATCH 1/3] conf: Set rebootTimeout valid range to 0..0xffff
On Tue, Oct 15, 2019 at 4:04 PM Michal Privoznik <mprivozn(a)redhat.com>
wrote:
On 10/15/19 7:23 AM, Han Han wrote:
> Hi Michal,
> Any more advice update?
Well, as I've said earlier, since we document that -1 is accepted value
and it means that it suppresses automatic reboots we need a way to
preserve this behaviour. For instance, what happens if you don't put
reboot-timeout onto the cmd line at all? Does qemu use some default and
If no reboot-timeout, qemu will not reboot by default. I have updated the
qemu doc:
https://github.com/qemu/qemu/commit/bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8
reboot anyways? If it doesn't reboot then -1 should mean to not
put
I think they use the same defaults and will not reboot by default. That can
be checked by
the code before and after qemu commit ee5d0f8. The values passed to
fw_cfg_add_file are
same by default.
Markus Armbruster,
Could you please confirm that, for cases of
- reboot-timeout=-1 before ee5d0f8
- reboot-timeout by default before ee5d0f8
- reboot-timeout by default after ee5d0f8
they all will not reboot?
reboot-timeout onto the cmd line. However, if it does reboot then we
need to talk to qemu developers to provide us a way to suppress
automatic reboots.
Michal
--
Best regards,
-----------------------------------
Han Han
Quality Engineer
Redhat.
Email: hhan(a)redhat.com
Phone: +861065339333
Attachments:
- attachment.html (text/html — 2.5 KB)