Re: [libvirt] [3/3] Implement RHEL-5.4 KVM QXL support in QEMU driver

Comments for commit grabbed from gitorious and apparently not updated as this commit now inclides the spice activating code and tests too... Daniel Author: Daniel P. Berrange <berrange(a)redhat.com&gt;    Implement RHEL-5.4 KVM QXL support in QEMU driver    This supports the -qxl argument in RHEL-5's fork of KVM    which has SPICE support. QXL is a graphics card, but    inexplicably doesn't use the standard -vga syntax for    generic configuration. Also -qxl is rather useless unless    you also supply -spice (coming in next patch)    * src/qemu_conf.c: Probe for -qxl arg in QEMU help. Format a      -qxl arg for launching VMs    * src/qemu_conf.h: Add flag for -qxl arg availability    * tests/qemuhelpdata/kvm-83-rhel, tests/qemuhelptest.c: test      for -qxl arg help parsing    * tests/qemuxml2argvtest.c, tests/qemuxml2xmltest.c,      tests/qemuxml2argvdata/qemuxml2argv-graphics-spice.args,      tests/qemuxml2argvdata/qemuxml2argv-graphics-spice.xml: add      tests for -qxl graphics XML to ARGV handling

@@ -3943,6 +3997,26 @@ int qemudBuildCommandLine(virConnectPtr conn,                 goto error;             }         } + +        if (def->videos[0]->type == VIR_DOMAIN_VIDEO_TYPE_QXL) { + +            if (qemuCmdFlags & QEMUD_CMD_FLAG_QXL) { +                char *optstr; + +                if (virAsprintf(&optstr, "%u,ram=%u", +                                def->videos[0]->heads, +                                (def->videos[0]->vram /1024)) < 0) +                    goto no_memory; + +                ADD_ARG_LIT("-qxl"); +                ADD_ARG(optstr); +            } else { +                qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, "%s", +                                 _("qxl graphics are not supported with this QEMU"));