Re: [libvirt] [PATCH 5/6] iscsi: Inhibit autologin for only libvirt managed targets

On 05/13/2016 05:29 PM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1331552 > > Based on code originally posted by Fritz Elfert <fritz(a)fritz-elfert.de&gt; > to remove the Autologin code entirely from libvirt, but reworked to only > set Autologin for libvirt managed targets. > > Commit id '3c12b654' took a "large hammer" approach to inhibiting logins > which causes issues if there are iSCSI targets not being managed by libvirt. > > Now that the previous commit ensures that the iscsi initiator doesn't update > the /var/lib/iscsi tree with the results for a 'sendtargets' by using the > "--op nonpersistent" option, let's remove the code from virISCSIScanTargets > that disables autologin for every target, but add that same setting into > the start pool code for each managed/started target to ensure that nothing > else goes and tries to autologin. > > Signed-off-by: John Ferlan <jferlan(a)redhat.com&gt; > --- > src/storage/storage_backend_iscsi.c | 11 +++++++++++ > src/util/viriscsi.c | 15 ++------------- > 2 files changed, 13 insertions(+), 13 deletions(-) > Over the weekend I got more "data" on this from Fritz... Seems with targets implemented by external SAN hardware, the host has a single iSCSI initiator with multiple targets. The claim is libvirt doesn't need the targets in manual mode. I'm still trying to process

that so patches 3-5 could need more adjustment. The adjustment being the removal of the autologin code. Since patch 4 would add the "--op nonpersistent" to the listing command line, the adjustment made to the /var/lib/iscsi doesn't happen. Still trying to process that feedback. I

did find that even with this patch applied, if something runs the "--mode discovery" without the "--op nonpersistent" (something other than libvirt), then the mode in the /var/lib/iscsi goes *back to* automatic. So in a way, it doesn't matter what we set this to, it can

be overridden. So what's the point of setting it then <sigh>. Was really trying to follow the spirit of the original change...