Re: [Libvir] PATCH: Process QEMU monitor at startup
On Mon, Mar 05, 2007 at 09:10:03AM +0000, Mark McLoughlin wrote:
Hi Dan,
Looks fine to commit, but how about re-factoring out the
read/poll/check loop? Suggested, but untested, patch attached.
I commited the patch with your suggested re-factoring applied too - I made
one tiny change to allow us to distinguish errors reading the STDERR from
errors reading the monitor PTY data.
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|