Re: [libvirt] [PATCH v2 4/7] dumpxml: let blockinfo reuse virStorageSource
On 18/11/14 09:35 -0700, Eric Blake wrote:
On 11/18/2014 08:00 AM, Adam Litke wrote:
> On 18/11/14 06:31 -0700, Eric Blake wrote:
>> In a future patch, the implementation of VIR_DOMAIN_XML_BLOCK_INFO
>> will use information stored in virStorageSource. In order to
>> maximize code reuse, it is easiest if BlockInfo code also uses the
>> same location for information.
>>
>> +++ b/src/util/virstoragefile.h
>> @@ -252,8 +252,9 @@ struct _virStorageSource {
>>
>> virStoragePermsPtr perms;
>> virStorageTimestampsPtr timestamps;
>> - unsigned long long allocation; /* in bytes, 0 if unknown */
>> unsigned long long capacity; /* in bytes, 0 if unknown */
>> + unsigned long long allocation; /* in bytes, 0 if unknown */
>
> (Pedantic and superficial) allocation dropped and re-added. Maybe you
> prefer it to appear after capacity in light of physical now being
> present?
Just reordering fields so that they come in the same order as their
public struct virDomainBlockInfo counterpart in libvirt-domain.h.
I suspected there was a good reason for it :)
Order doesn't strictly matter, if you want me to avoid the churn.
Nope, please keep it the way you have it.
--
Adam Litke