Re: [libvirt] [PATCH 5/4] qemuDomainBlockPull: Validate base in on the backing chain
On 04/24/2014 07:15 AM, Jiri Denemark wrote:
This patch also adds support for addressing backing stores by index
for
this API.
Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
---
Notes:
- should probably be just squashed into the previous patch
Yeah, squashing makes sense.
src/qemu/qemu_driver.c | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
Any further libvirt.c doc changes that should go along with this one?
qemuDomainObjEnterMonitor(driver, vm);
- /* XXX - libvirt should really be tracking the backing file chain
- * itself, and validating that base is on the chain, rather than
- * relying on qemu to do this. */
Yay, fixing another one of my XXX comments!
ACK
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)