Re: [libvirt] [PATCH] bhyve: add domainCreateWithFlags support
Michal Privoznik wrote:
If this fails, we should kill the domain and return an error. It
won't happen currently, as ret is equal to zero in this area of code (it's not
visible in the context, but this whole block starts with 'if (ret == 0) {').
Moreover, the same bug is present a few line above, just at the beginning of the block. So
the code I'm aiming at looks like this:
Thanks for noticing that!
ACK with that squashed in.
Pushed, thanks for the review,
Roman Bogorodskiy
Attachments:
- attachment.sig (application/pgp-signature — 488 bytes)