Re: [libvirt] [PATCH] locking: Add io_timeout to sanlock
On 27.10.2015 10:23, Martin Kletzander wrote:
On Fri, Oct 23, 2015 at 01:37:54PM +0200, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1251190
>
> So, if domain loses access to storage, sanlock tries to kill it
> after some timeout. So far, the default is 80 seconds. But for
> some scenarios this might not be enough. We should allow users to
> adjust the timeout according to their needs.
>
Shouldn't we check for whether the current sanlock version supports
that? Or require new enough version in configure/libvirt.spec? I
understand the _timeout option was added later then the previous one.
Otherwise looks good, if you convince me that there is no need for the
check then it can go in as it is.
The _timeout was added in e174a7e33728ba3ad587546693612476a081735d
(sanlock-2.5~5) which dates back to Aug 2012. So I'd say since we are
more than three years since then we are safe. But if you would feel
safer with an explicit check I can do that.
Michal