Re: [libvirt] [PATCH] allow (only) surrounding whitespace in uuid
On Sat, Jan 23, 2010 at 05:43:41PM +0200, Dan Kenigsberg wrote:
On Thu, Jan 21, 2010 at 03:33:21PM +0100, Daniel Veillard wrote:
> On Tue, Jan 05, 2010 at 02:51:06PM +0200, Dan Kenigsberg wrote:
> > Please consider something along these lines. Without it, pretty-printed
> > domxml is rejected due to the whitespace before uuid, and long long
> > string of hexadecimal digits is accepted.
> > ---
>
> Yes that looks fine to me and testing for NUL termination sound
> important, ACK,
>
> pushed, thanks !
Thank you. Though since I've sent that, I noticed that surrounding
whitespace is a more general problem of xml text nodes, such as the
<os><type> element.
Should libvirt consider any surrounding whitespace as insignificant?
No, IMHO we should preserve all whitespace. I don't actually agree
with the patch that DV just committed to trim whitespace in UUID
since it introduces a one-off special case in the XML handling when
none of the other elements are trimmed.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|