Re: [libvirt] [PATCH] conf: Fix ABI stability check for spicevmc channel
On 08/17/2012 06:20 AM, Jiri Denemark wrote:
Change device type of a virtio channel from/to spicevmc is not a
user
visible change. However, spicevmc channels use different default target
name than other virtio channels. To maintain ABI stability during this
change target name must be explicitly specified (and equal) in both
configurations.
Can we go from 'non-spice, no name' to 'spice, explicit name that
matches old non-spice default name'? Can we go from 'spice, no name' to
'non-spice, explicit name that matches old spice default name'? Your
patch prevents those, even if it is technically possible.
For that matter, can we even go from 'non-spice, no name' to 'non-spice,
explicit default name'? If we can, then the user can achieve the
earlier task through two steps.
---
src/conf/domain_conf.c | 9 +++++++++
1 file changed, 9 insertions(+)
We may have more work given the above question, but I'd rather be
stricter than necessary and safe than allow a real problem, so I'm okay
with this patch as-is, even if it is too tight for some corner cases of
adding a compatible name.
ACK.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)