Re: [PATCH v1 15/25] Deprecate 32 bit big-endian MIPS
Thomas Huth <thuth(a)redhat.com> writes:
On 26/08/2022 19.21, Alex Bennée wrote:
<snip>
> - * - MIPS
> + * - MIPS (LE only)
I'd replace "LE" with "little endian" - not everybody might know
that
abbreviation.
<snip>
>
+'''''''''''''''''''
> +
> +A Debian 10 ("Buster") moved into LTS the big endian 32 bit version of
s/A Debian/As Debian/
Fixed.
> +MIPS moved out of support making it hard to maintain our
> +cross-compilation CI tests of the architecture. As we no longer have
> +CI coverage support may bitrot away before the deprecation process
> +completes. The little endian variants of MIPS (both 32 and 64 bit) are
> +still a supported host architecture.
> +
> QEMU API (QAPI) events
> ----------------------
...
> diff --git a/tests/docker/dockerfiles/debian-mips-cross.docker
> b/tests/docker/dockerfiles/debian-mips-cross.docker
> index 26c154014d..75943619df 100644
> --- a/tests/docker/dockerfiles/debian-mips-cross.docker
> +++ b/tests/docker/dockerfiles/debian-mips-cross.docker
> @@ -1,32 +1,14 @@
> #
> -# Docker mips cross-compiler target
> +# Docker cross-compiler target
Why did you remove the "mips" here?
You may notice most of the flattened cross compiler docker images are
basically the same save the last two lines. I ended up just copy pasting
the preamble as I went along. I could restore if you like.
Thomas
--
Alex Bennée