On 07/15/2015 12:33 PM, Peter Krempa wrote:
This series refactors the block job command code so that it is
handled by
separate functions rather than one mega-method. Additionally this series then
fixes the routine for waiting for a block job.
As it's perhaps obvious from the patches the API design for the block job APIs
is rather unfortunate for users.
This series contains a few patches that already were submitted and partially
reviewed previously.
Peter Krempa (13):
virsh: blockjob: Extract block job info code into a separate function
virsh: cmdBlockJob: Switch to declarative flag interlocking
virsh: blockjob: Split out vshBlockJobSetSpeed from blockJobImpl
virsh: block job: separate abort from blockJobImpl
virsh: Split out block pull implementation from blockJobImpl
virsh: Kill blockJobImpl by moving the final impl into cmdBlockCommit
virsh: Refactor argument checking in cmdBlockCommit
virsh: Refactor argument handling in cmdBlockCopy
virsh: Refactor argument handling in cmdBlockPull
qemu: Update state of block job to READY only if it actually is ready
virsh: Refactor block job waiting in cmdBlockPull
virsh: Refactor block job waiting in cmdBlockCommit
virsh: Refactor block job waiting in cmdBlockCopy
src/qemu/qemu_driver.c | 10 +-
src/qemu/qemu_monitor.h | 1 +
src/qemu/qemu_monitor_json.c | 7 +
tools/virsh-domain.c | 962 ++++++++++++++++++++++++-------------------
4 files changed, 551 insertions(+), 429 deletions(-)
Noted a couple of minor things, but looks good otherwise.
ACK series,
John