Re: [libvirt] [PATCH 0/3] bhyve: allow locking memory

Peter Krempa wrote: > On Sun, May 13, 2018 at 14:01:25 +0400, Roman Bogorodskiy wrote: >> Fabian Freyer wrote: > > [...] > >>> 13 files changed, 134 insertions(+) >>> create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-wired.args >>> create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-wired.xml >>> create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-wired.args >>> create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-wired.ldargs >>> create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-wired.xml >>> create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-wired.xml >> >> Thanks for the patches, I've pushed the series with some syntax-check >> fixes (trailing whitespaces, tabs instead of whitespaces) and added >> 'Signed-off-by' line which is mandatory now. > > Note that 'Signed-off-by' should _NOT_ be added without explicit consent > of the author of the patches. Otherwise it defeats the purpose of > certification that the author agrees and complies with the Developer > certificate of origin. Adding it without explicit consent makes the > Signed-off-by line just a useless piece of jewelery added to appease the > push hook. Oh, sorry about that. I assumed as Fabian is a long time contributor, he's familiar with the general project policies. Fabian, do you have any issue with that?