Re: [libvirt] [PATCH 22/34] Removed virDomainEventPtr in favor of virObjectEventPtr
On Fri, Nov 29, 2013 at 04:18:58PM +0100, Cédric Bosdonnat wrote:
The virDomainEvent class wasn't defining anything special, thus
it has
been dropped.
diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c
index 7694fcc..d4ecc23 100644
--- a/src/conf/domain_event.c
+++ b/src/conf/domain_event.c
@@ -107,16 +105,11 @@ static void
virDomainEventDeviceRemovedDispose(void *obj);
struct _virObjectEvent {
virObject parent;
int eventID;
-};
-
-struct _virDomainEvent {
- virObjectEvent parent;
-
virObjectMeta meta;
};
Ok, so you're merging virObjectMeta into the parent class. I understand why
you want to keep a single set of metadata for all object types. This does
mostly work. We should be aware of the fact that different objects have
a different set of valid attributes
- virDomainPtr - id, name, uuid
- virNetworkPtr - name, uuid
- virStoragePoolPtr - name, uuid
- virInterfacePtr - name
- virSecretPtr - uuid
- virNodeDevicePtr - name
- virNWfilterPtr - name, uuid
Even if we don't store any custom data in the virDomainEvent class its
existance does tell you information about the metadata attributes that
are valid for this class. Even if we don't use it right now, this feels
like a useful class representation to have available.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|