Re: [libvirt] [PATCH] Fix reporting of i/o errors by iohelper process

On 07/16/2014 08:12 AM, Jason J. Herne wrote: > From: "Jason J. Herne" <jjherne(a)us.ibm.com&gt; > > libvirt_iohelper is a helper process that is exec'ed and used to handle I/O > during a Qemu managed save operation. Due to a missing call to > virFileWrapperFdClose, all I/O error messages reported by iohelper are lost. > > This patch adds a call to virFileWrapperFdClose to the cleanup phase of > qemuDomainSaveMemory. > > This patch also modifies virFileWrapperFdClose such that errors are only > reported when the length of the err_msg buffer is > 0. Before now, the > existence of the buffer would trigger error reporting in virFileWrapperFdClose. > > Signed-off-by: Jason J. Herne <jjherne(a)us.ibm.com&gt; > --- > src/qemu/qemu_driver.c | 1 + > src/util/virfile.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) Nice! Thanks for persevering on this one. Congrats on your first libvirt patch.

> > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index ecccf6c..8d78805 100644 > --- a/src/qemu/qemu_driver.c > +++ b/src/qemu/qemu_driver.c > @@ -3015,6 +3015,7 @@ qemuDomainSaveMemory(virQEMUDriverPtr driver, > > cleanup: > VIR_FORCE_CLOSE(fd); > + virFileWrapperFdClose(wrapperFd); > virFileWrapperFdFree(wrapperFd); > VIR_FREE(xml);